Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] Migrate web_widget_plotly_chart #2815

Merged
merged 23 commits into from
May 8, 2024

Conversation

robyf70
Copy link
Contributor

@robyf70 robyf70 commented May 3, 2024

Migrated to v17

@robyf70 robyf70 force-pushed the 17.0-mig-web_widget_plotly_chart branch from 962c3f6 to 020c8a0 Compare May 3, 2024 14:07
@robyf70 robyf70 force-pushed the 17.0-mig-web_widget_plotly_chart branch from 020c8a0 to 0a1432d Compare May 6, 2024 10:16
Copy link

@ccandito ccandito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@robyf70
Copy link
Contributor Author

robyf70 commented May 8, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @robyf70 you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@robyf70
Copy link
Contributor Author

robyf70 commented May 8, 2024

@pedrobaeza Why I cannot merge as maintainer of this module?

@pedrobaeza
Copy link
Member

It can be considered as a bug. As there's a file requirements.txt outside the folder, the bot considers that you are touching something outside your scope.

/ocabot migration web_widget_plotly_chart
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 8, 2024
26 tasks
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-2815-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0e61deb into OCA:17.0 May 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6ff8158. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.