Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] web_group_expand #2863

Merged
merged 22 commits into from
Jul 3, 2024
Merged

[17.0][MIG] web_group_expand #2863

merged 22 commits into from
Jul 3, 2024

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Jun 27, 2024

No description provided.

mga-odoo and others added 16 commits June 27, 2024 21:50
@astirpe astirpe marked this pull request as ready for review June 27, 2024 20:05
@astirpe astirpe mentioned this pull request Jun 28, 2024
Open
27 tasks
@CRogos
Copy link
Contributor

CRogos commented Jun 28, 2024

@sbidoul any idea why runboat is missing here?

@sbidoul
Copy link
Member

sbidoul commented Jun 28, 2024 •
edited
Loading

The runboat build is there but for some reason, the GitHub status API call failed with This SHA and context has reached the maximum number of statuses. No idea what this means for now.

@sbidoul
Copy link
Member

sbidoul commented Jun 28, 2024

This happens for all PRs. I suspect a GitHub issue. Will wait a bit to see if it resolves itself.

CRogos
CRogos approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine.

Some of the commits in the history could be merged.
image

flotho
flotho approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on runboat
LGTM

oca-ci and others added 5 commits July 1, 2024 19:17
@astirpe
[UPD] Update web_group_expand.pot
3e7cf78 
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_group_expand/
@Ivorra78 @astirpe
Translated using Weblate (Spanish)
efac1f6 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-16.0/web-16.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_group_expand/es/
@adrianojprado @astirpe
Translated using Weblate (Portuguese (Brazil))
547bcfd 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-16.0/web-16.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_group_expand/pt_BR/
@mymage @astirpe
Added translation using Weblate (Italian)
96e54b1 
Translated using Weblate (Italian)

Currently translated at 100.0% (2 of 2 strings)

Translation: web-16.0/web-16.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_group_expand/it/
@astirpe
[MIG] web_group_expand: pre-commit
7d42f97
@astirpe
Copy link
Member Author

astirpe commented Jul 1, 2024

Commits squashed, thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor

CRogos commented Jul 3, 2024

@pedrobaeza can you merge?

@pedrobaeza
Copy link
Member

/ocabot migration web_group_expand

Merging following reviews:

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 3, 2024
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2863-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 60abf88 into OCA:17.0 Jul 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e2d9b8e. Thanks a lot for contributing to OCA. ❤️

trisdoan pushed a commit to trisdoan/web that referenced this pull request Jul 20, 2024
@OCA-git-bot @trisdoan
Merge PR OCA#2863 into 17.0
833ca2c 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogos CRogos CRogos approved these changes

@flotho flotho flotho approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.