[16.0][IMP] web_timeline - add attribute color_field to be able to specify the bar color in data through a field value #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tarteo, |
IJOL
force-pushed
the
16.0-web_timeline-color_field
branch
from
477ee27
to
8e76c77
Compare
IJOL
force-pushed
the
16.0-web_timeline-color_field
branch
from
8e76c77
to
c7bb043
Compare
IJOL
changed the title
|
hi @pedrobaeza can you take a look at this one too? Thanks in advance |
|
Please follow commit message guidelines: and put the purpose of the changes in a explained way. |
IJOL
force-pushed
the
16.0-web_timeline-color_field
branch
2 times, most recently
from
c5ce1aa
to
4f62ab5
Compare
There was a problem hiding this comment.
Tested code and functionality; everything works as expected. Just two remaining points from my side:
- I noticed a difference between
READMEandCONFIGURE. Please runpre-committo generate theREADMEfrom fragments instead of editing it manually. - Please update the commit message according to the guidelines provided by Pedro.
IJOL
force-pushed
the
16.0-web_timeline-color_field
branch
from
4f62ab5
to
04df48b
Compare
IJOL
force-pushed
the
16.0-web_timeline-color_field
branch
2 times, most recently
from
427d810
to
4805627
Compare
…_field", to be able to directly specify the color of the bar by reading a char field compatible with widget="color" from view's model, the "colors" attribute take precedence over the new "color_field" attribute
IJOL
force-pushed
the
16.0-web_timeline-color_field
branch
from
4805627
to
61852cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new attribute to the view element, to be able to directly specify the color of the bar by reading a char field compatible with widget="color" from view's model, the "colors" attribute take precedence over the new "color_field" attribute