Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] web_advanced_search: display label name in partners search #2983

Conversation

yajo
Copy link
Member

@yajo yajo commented Nov 8, 2024

Without this patch, when searching in the res.partner view for 'Tags is equal to "Something"', the search bar would display "Tags is equal to "123"' (the tag ID instead of its display name).

Before:
image

After:
image

@moduon MT-7870

Without this patch, when searching in the `res.partner` view for 'Tags is equal to "Something"', the search bar would display "Tags is equal to "123"' (the tag ID instead of its display name).

@moduon MT-7870
@OCA-git-bot
Copy link
Contributor

Hi @ivantodorovich,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@edlopen edlopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also I've tested it in runboat. Such a nice feature @yajo !!

@yajo
Copy link
Member Author

yajo commented Nov 8, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2983-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d33bfc5 into OCA:16.0 Nov 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 91a9800. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-web_advanced_search-fix_partner_label_search_display_name branch November 12, 2024 07:48
@StefanRijnhart StefanRijnhart changed the title [FIX] web_advanced_search: display label name in partners search [16.0][FIX] web_advanced_search: display label name in partners search Dec 2, 2024
@StefanRijnhart StefanRijnhart added this to the 16.0 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants