Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_widget_product_label_section_and_note: Migration to version 17.0 #3080

Open
wants to merge 6 commits into
base: 17.0
Choose a base branch
from

Conversation

carlos-lopez-tecnativa
Copy link
Contributor

TT54841
@Tecnativa @pedrobaeza @chienandalu @legalsylvain could you please review this.

… for multiline text.

Before this change, when the text was large and multiline, the textarea did not resize, and the text was not displayed correctly. Now, the textarea adjusts according to the text. These changes are backported from V18.
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-mig-web_widget_product_label_section_and_note branch from a75c181 to ec6b186 Compare February 5, 2025 16:16
@pedrobaeza
Copy link
Member

/ocabot migration web_widget_product_label_section_and_note

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 5, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 5, 2025
31 tasks
@pedrobaeza
Copy link
Member

Tested functionally in the base DB, as the other is very contaminated by things like the classic theme.

This problem was present also on 16.0 version, but let's tackle it (and maybe backport the fix): the "not show" the product name is not preserved when changing the rest of the text:

Peek 05-02-2025 20-19

About the migration itself, 2 comments:

  • The grey background color for opening the product is normal?
  • On the sales order, the widget is not working the same as it did in 16. Please check.

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-mig-web_widget_product_label_section_and_note branch from ec6b186 to 27024ba Compare February 6, 2025 11:39
@carlos-lopez-tecnativa
Copy link
Contributor Author

About the migration itself, 2 comments:

  • The grey background color for opening the product is normal?

I updated the style to V17, following the many2one style.

  • On the sales order, the widget is not working the same as it did in 16. Please check.

I remember that in sales, it did not work if the sale_product_configurator module was installed(the ROADMAP states this). I deactivated the view on Runboat, and now it is working. Please check again. Additionally, I remember that you changed this module to auto_install=False, but it is still installed on Runboat. I don’t know why.
https://github.com/OCA/OCB/pull/1242/files#diff-6d2599689bebadcbba9c676b8656305600bcdcf0c2b359f57cdef023136ef065R29

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-mig-web_widget_product_label_section_and_note branch from 27024ba to 2272808 Compare February 6, 2025 14:37
@carlos-lopez-tecnativa
Copy link
Contributor Author

This problem was present also on 16.0 version, but let's tackle it (and maybe backport the fix): the "not show" the product name is not preserved when changing the rest of the text:

I added a separate commit to fix this. Please try again and let me know if it is okay for you, and if it can be backported to V16.

… the icon based on product visibility.

Before this commit, when isProductVisible was disabled and the user changed the label, this caused isProductVisible to change its value.
After this commit, changing the label no longer modifies isProductVisible.
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 17.0-mig-web_widget_product_label_section_and_note branch from 2272808 to 65af83d Compare February 6, 2025 14:39
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. You can backport the latest fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants