-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] web_widget_product_label_section_and_note: Migration to version 17.0 #3080
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] web_widget_product_label_section_and_note: Migration to version 17.0 #3080
Conversation
…the product and name into a single column.
… for multiline text. Before this change, when the text was large and multiline, the textarea did not resize, and the text was not displayed correctly. Now, the textarea adjusts according to the text. These changes are backported from V18.
a75c181
to
ec6b186
Compare
/ocabot migration web_widget_product_label_section_and_note |
Tested functionally in the base DB, as the other is very contaminated by things like the classic theme. This problem was present also on 16.0 version, but let's tackle it (and maybe backport the fix): the "not show" the product name is not preserved when changing the rest of the text: About the migration itself, 2 comments:
|
ec6b186
to
27024ba
Compare
I updated the style to V17, following the many2one style.
I remember that in sales, it did not work if the |
27024ba
to
2272808
Compare
I added a separate commit to fix this. Please try again and let me know if it is okay for you, and if it can be backported to V16. |
… the icon based on product visibility. Before this commit, when isProductVisible was disabled and the user changed the label, this caused isProductVisible to change its value. After this commit, changing the label no longer modifies isProductVisible.
2272808
to
65af83d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working. You can backport the latest fix.
resizeTextArea
function, as it is now included in Odoo 17.resizeInput
is not exportable, so it still needs to be kept. See https://github.com/odoo/odoo/blob/30f7928ac42c8536a6179b96ed7f8aa9d0f14374/addons/web/static/src/core/utils/autoresize.js#L42useAutoresize
is available in Odoo 17, but it does not support passing anonResize
function in theoptions
. Therefore, the existing code must be retained as well.V17
https://github.com/odoo/odoo/blob/30f7928ac42c8536a6179b96ed7f8aa9d0f14374/addons/web/static/src/core/utils/autoresize.js#L26
V18
https://github.com/odoo/odoo/blob/3757daca84dc080a276c04f310262a3ddf340a0f/addons/web/static/src/core/utils/autoresize.js#L27
TT54841
@Tecnativa @pedrobaeza @chienandalu @legalsylvain could you please review this.