Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] website_cookiefirst: Migration to 16.0 #945

Merged
merged 11 commits into from
Jun 14, 2023
Merged

[16.0][MIG] website_cookiefirst: Migration to 16.0 #945

merged 11 commits into from
Jun 14, 2023

Conversation

ioans73
Copy link
Member

@ioans73 ioans73 commented Jan 26, 2023

Standard migration

@ioans73 ioans73 mentioned this pull request Jan 26, 2023
Open
13 tasks
@ioans73 ioans73 force-pushed the 16.0-mig_website_cookiefirst branch from ca4c132 to 4746ac3 Compare January 26, 2023 08:16
@matteoopenf
Copy link
Contributor

I made a fix in 14.0, I think you should evaulte to port the fix

@NICO-SOLUTIONS
Copy link
Member

Functional review..
looks good to me

@ao-landoo
Copy link

@ioans73 Can you rebase or apply commit @matteoopenf is mentioning?

@ioans73
Copy link
Member Author

ioans73 commented May 16, 2023

@ao-landoo @matteoopenf is this commit?ffe59df

@matteoopenf
Copy link
Contributor

@ao-landoo @matteoopenf is this commit?ffe59df

I confirm, thanks

@ioans73 ioans73 force-pushed the 16.0-mig_website_cookiefirst branch from 4746ac3 to c9aa87c Compare May 16, 2023 13:25
ao-landoo
ao-landoo approved these changes May 16, 2023
View reviewed changes
Copy link

@ao-landoo ao-landoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical approval

@matteoopenf
Copy link
Contributor

Technical approval

I don't see my commit ...

@ioans73 ioans73 force-pushed the 16.0-mig_website_cookiefirst branch from c9aa87c to 922eef4 Compare May 16, 2023 13:44
@ao-landoo
Copy link

Was your commit taken to V15?

@ioans73
Copy link
Member Author

ioans73 commented May 16, 2023

Finally I have modified the xpath, but keeping the same template, since that element is added in website.footer_copyright_company_name and not in website.layout

@ioans73 ioans73 force-pushed the 16.0-mig_website_cookiefirst branch from 922eef4 to bab2d98 Compare May 16, 2023 13:48
@matteoopenf
Copy link
Contributor

Was your commit taken to V15?

is in 14.0 ffe59df

@matteoopenf
Copy link
Contributor

Was your commit taken to V15?

also in 14.0 broken if threre isn't the fix the translation is broken

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ioans73
Copy link
Member Author

ioans73 commented May 17, 2023

@OCA/website-maintainers could you merge please?

@ioans73
Copy link
Member Author

ioans73 commented Jun 14, 2023

@pedrobaeza could you merge please?

@pedrobaeza pedrobaeza changed the title [MIG] website_cookiefirst: Migration to 16.0 [16.0][MIG] website_cookiefirst: Migration to 16.0 Jun 14, 2023
@pedrobaeza
Copy link
Member

/ocabot migration website_cookiefirst
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 14, 2023
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-945-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 943c604 into OCA:16.0 Jun 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4212863. Thanks a lot for contributing to OCA. ❤️

@ioans73 ioans73 deleted the 16.0-mig_website_cookiefirst branch June 14, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ao-landoo ao-landoo ao-landoo approved these changes

@fuentes73 fuentes73 fuentes73 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@ioans73 @matteoopenf @NICO-SOLUTIONS @ao-landoo @OCA-git-bot @pedrobaeza @fuentes73 @oca-travis @ferran-S73 @mymage