-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] website_crm_privacy_policy: Migration to 16.0 #947
[16.0][MIG] website_crm_privacy_policy: Migration to 16.0 #947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Review: LGTM
- Fix review comments - Icon changed - Remove website_legal_page depedency - Set Privacy policy link for opening in new tab, in order to not change user focus and avoid losing any data entered by user in contactus form - [IMP] README and OCA as author OCA Transbot updated translations from Transifex
… test fails on this dead link.
New `website_form` addon includes an undocumented validation system. By simply adapting layout to what it wants, we get validation for free.
[UPD] Update website_crm_privacy_policy.pot
[UPD] Update website_crm_privacy_policy.pot [UPD] README.rst
[UPD] Update website_crm_privacy_policy.pot [UPD] README.rst [UPD] README.rst
497e84c
to
f57eba6
Compare
This PR has the |
@pedrobaeza can you merge this? |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at c95ea5e. Thanks a lot for contributing to OCA. ❤️ |
Standard migration.
Depends: