Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_crm_privacy_policy: Migration to 16.0 #947

Merged
merged 18 commits into from
Jun 28, 2023

Conversation

miguel-S73
Copy link
Contributor

@miguel-S73 miguel-S73 commented Jan 26, 2023

@miguel-S73 miguel-S73 mentioned this pull request Jan 26, 2023
13 tasks
Copy link

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM

antespi and others added 18 commits May 17, 2023 08:17
- Fix review comments
- Icon changed
- Remove website_legal_page depedency
- Set Privacy policy link for opening in new tab, in order to not change user focus and avoid losing any data entered by user in contactus form
- [IMP] README and OCA as author

OCA Transbot updated translations from Transifex
New `website_form` addon includes an undocumented validation system.
By simply adapting layout to what it wants, we get validation for free.
[UPD] Update website_crm_privacy_policy.pot
[UPD] Update website_crm_privacy_policy.pot

[UPD] README.rst
[UPD] Update website_crm_privacy_policy.pot

[UPD] README.rst

[UPD] README.rst
@miguel-S73 miguel-S73 force-pushed the 16.0-mig-website_crm_privacy_policy branch from 497e84c to f57eba6 Compare May 17, 2023 06:18
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ioans73
Copy link
Member

ioans73 commented Jun 28, 2023

@pedrobaeza can you merge this?

@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration website_crm_privacy_policy

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 28, 2023
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-947-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5ab2cd2 into OCA:16.0 Jun 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c95ea5e. Thanks a lot for contributing to OCA. ❤️

@ioans73 ioans73 deleted the 16.0-mig-website_crm_privacy_policy branch June 28, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.