[ADD] stock_available_to_promise_release_restrict_lot

setup/stock_available_to_promise_release_restrict_lot/odoo/addons/stock_available_to_promise_release_restrict_lot

@@ -0,0 +1 @@
+../../../../stock_available_to_promise_release_restrict_lot

setup/stock_available_to_promise_release_restrict_lot/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)

stock_available_to_promise_release/README.rst

@@ -139,6 +139,7 @@ Contributors
 * Dung Tran <dungtd@trobz.com>
 * Laurent Mignon <laurent.mignon@acsone.eu>
 * Michael Tietz (MT Software) <mtietz@mt-software.de>
+* Souheil Bejaoui <soueil.bejaoui@acsone.eu>
 
 Other credits
 ~~~~~~~~~~~~~

stock_available_to_promise_release/models/stock_move.py

@@ -401,31 +401,31 @@ def _get_ordered_available_to_promise_by_warehouse(self, warehouse):
             item["product_id"][0]: item["quantity"] for item in location_quants
         }
         for move in self:
-            product_uom = move.product_id.uom_id
-            previous_promised_qty = move.previous_promised_qty
-
-            rounding = product_uom.rounding
-            available_qty = float_round(
-                quants_available.get(move.product_id.id, 0.0),
-                precision_rounding=rounding,
-            )
-
-            real_promised = available_qty - previous_promised_qty
-            uom_promised = product_uom._compute_quantity(
-                real_promised,
-                move.product_uom,
-                rounding_method="HALF-UP",
-            )
-            res[move] = {
-                "ordered_available_to_promise_uom_qty": max(
-                    min(uom_promised, move.product_uom_qty), 0.0
-                ),
-                "ordered_available_to_promise_qty": max(
-                    min(real_promised, move.product_qty), 0.0
-                ),
-            }
+            available_qty = quants_available.get(move.product_id.id, 0.0)
+            res[move] = move._get_ordered_available_to_promise_qty(available_qty)
         return res
 
+    def _get_ordered_available_to_promise_qty(self, available_qty):
+        self.ensure_one()
+        product_uom = self.product_id.uom_id
+        rounding = product_uom.rounding
+        previous_promised_qty = self.previous_promised_qty
+        available_qty = float_round(available_qty, precision_rounding=rounding)
+        real_promised = available_qty - previous_promised_qty
+        uom_promised = product_uom._compute_quantity(
+            real_promised,
+            self.product_uom,
+            rounding_method="HALF-UP",
+        )
+        return {
+            "ordered_available_to_promise_uom_qty": max(
+                min(uom_promised, self.product_uom_qty), 0.0
+            ),
+            "ordered_available_to_promise_qty": max(
+                min(real_promised, self.product_qty), 0.0
+            ),
+        }
+
     def _get_ordered_available_to_promise(self):
         res = {}
         moves_by_warehouse = self._group_by_warehouse()

stock_available_to_promise_release/readme/CONTRIBUTORS.rst

@@ -4,3 +4,4 @@
 * Dung Tran <dungtd@trobz.com>
 * Laurent Mignon <laurent.mignon@acsone.eu>
 * Michael Tietz (MT Software) <mtietz@mt-software.de>
+* Souheil Bejaoui <soueil.bejaoui@acsone.eu>

stock_available_to_promise_release/static/description/index.html

@@ -8,11 +8,10 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
-Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +274,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: gray; } /* line numbers */
+pre.code .ln { color: grey; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +300,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic, pre.problematic {
+span.problematic {
   color: red }
 
 span.section-subtitle {
@@ -477,6 +476,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Dung Tran &lt;<a class="reference external" href="mailto:dungtd&#64;trobz.com">dungtd&#64;trobz.com</a>&gt;</li>
 <li>Laurent Mignon &lt;<a class="reference external" href="mailto:laurent.mignon&#64;acsone.eu">laurent.mignon&#64;acsone.eu</a>&gt;</li>
 <li>Michael Tietz (MT Software) &lt;<a class="reference external" href="mailto:mtietz&#64;mt-software.de">mtietz&#64;mt-software.de</a>&gt;</li>
+<li>Souheil Bejaoui &lt;<a class="reference external" href="mailto:soueil.bejaoui&#64;acsone.eu">soueil.bejaoui&#64;acsone.eu</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="other-credits">
@@ -489,9 +489,7 @@ <h2><a class="toc-backref" href="#toc-entry-7">Other credits</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org">
-<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>

stock_available_to_promise_release_restrict_lot/README.rst

@@ -0,0 +1,111 @@
+===============================================
+Stock Available To Promise Release Restrict Lot
+===============================================
+
+.. 
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! source digest: sha256:62462fd44997edc1156593f1be5e631c8944a601041a92e568a58abe559ffbd8
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fwms-lightgray.png?logo=github
+    :target: https://github.com/OCA/wms/tree/16.0/stock_available_to_promise_release_restrict_lot
+    :alt: OCA/wms
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/wms-16-0/wms-16-0-stock_available_to_promise_release_restrict_lot
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/wms&target_branch=16.0
+    :alt: Try me on Runboat
+
+|badge1| |badge2| |badge3| |badge4| |badge5|
+
+This module acts as an integration layer between
+``stock_available_to_promise_release`` and ``stock_restrict_lot``,
+enabling advanced stock allocation based on both available-to-promise
+quantities and lot restrictions.
+
+By combining available-to-promise logic with lot restriction
+functionality, this module enhances stock move allocation by:
+
+-  Allowing stock moves to respect both priority and specific lot
+   allocations.
+-  Ensuring that available quantities are promised according to move
+   priority, but only when the lot matches the restriction.
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Use Cases / Context
+===================
+
+When both ``stock_available_to_promise_release`` and
+``stock_restrict_lot`` modules are installed, the calculation of
+quantities available to promise doesn't properly account for lot
+restrictions. This results in a priority conflict, where higher-priority
+moves that are restricted to a specific lot receive available quantities
+from any lot, bypassing their lot restriction.
+
+The issue manifests as follows:
+
+-  A move with a higher priority, restricted to a specific lot, is
+   promised the available quantity regardless of lot constraints.
+-  If the restricted lot is allocated to another move with lower
+   priority, the lower-priority move can not be promised its designated
+   lot.
+
+In effect, lot-restricted moves cannot accurately reserve quantities
+based on both priority and specific lot requirements. This can lead to
+stock release issues, where low-priority moves fail to secure stock from
+their restricted lots due to incorrect available to promise calculations
+in higher-priority moves.
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/wms/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us to smash it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/wms/issues/new?body=module:%20stock_available_to_promise_release_restrict_lot%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+-------
+
+* ACSONE SA/NV
+
+Contributors
+------------
+
+-  Souheil Bejaoui soueil.bejaoui@acsone.eu
+
+Maintainers
+-----------
+
+This module is maintained by the OCA.
+
+.. image:: https://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: https://odoo-community.org
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/wms <https://github.com/OCA/wms/tree/16.0/stock_available_to_promise_release_restrict_lot>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

stock_available_to_promise_release_restrict_lot/__init__.py

@@ -0,0 +1 @@
+from . import models

stock_available_to_promise_release_restrict_lot/__manifest__.py

@@ -0,0 +1,13 @@
+# Copyright 2024 ACSONE SA/NV
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+{
+    "name": "Stock Available To Promise Release Restrict Lot",
+    "version": "16.0.1.0.0",
+    "license": "AGPL-3",
+    "author": "ACSONE SA/NV,Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/wms",
+    "depends": ["stock_available_to_promise_release", "stock_restrict_lot"],
+    "data": [],
+    "demo": [],
+}

stock_available_to_promise_release_restrict_lot/models/__init__.py

@@ -0,0 +1 @@
+from . import stock_move

stock_available_to_promise_release_restrict_lot/models/stock_move.py

@@ -0,0 +1,85 @@
+# Copyright 2024 ACSONE SA/NV
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from odoo import models
+from odoo.osv.expression import AND, OR
+
+
+class StockMove(models.Model):
+
+    _inherit = "stock.move"
+
+    def _previous_promised_qty_sql_lateral_where(self, warehouse):
+        sql, params = super()._previous_promised_qty_sql_lateral_where(warehouse)
+        sql += "AND m.restrict_lot_id is null"
+        return sql, params
+
+    def _get_previous_restricted_lot_moves_domain(self):
+        return AND(
+            [
+                [
+                    ("restrict_lot_id", "=", self.restrict_lot_id.id),
+                    ("state", "not in", ["done", "cancel"]),
+                    ("id", "!=", self.id),
+                ],
+                OR(
+                    [
+                        [("priority", "=", self.priority)],
+                        [
+                            ("priority", "=", self.priority),
+                            ("date_priority", "<", self.date_priority),
+                        ],
+                        [
+                            ("priority", "=", self.priority),
+                            ("date_priority", "=", self.date_priority),
+                            ("id", "<", self.id),
+                        ],
+                    ]
+                ),
+            ]
+        )
+
+    def _get_previous_restricted_lot_moves(self):
+        self.ensure_one()
+        if not self.restrict_lot_id:
+            return self.browse()
+        return self.search(self._get_previous_restricted_lot_moves_domain())
+
+    def _get_previous_promised_qties(self):
+        restrict_lot_moves = self.filtered("restrict_lot_id")
+        no_restrict_lot_moves = self - restrict_lot_moves
+        res = super(StockMove, no_restrict_lot_moves)._get_previous_promised_qties()
+        for move in restrict_lot_moves:
+            previous_moves = self._get_previous_restricted_lot_moves()
+            res[move.id] = (
+                sum(previous_moves.mapped("product_uom_qty")) if previous_moves else 0
+            )
+        return res
+
+    def _get_ordered_available_to_promise_by_warehouse(self, warehouse):
+        restrict_lot_moves = self.filtered("restrict_lot_id")
+        no_restrict_lot_moves = self - restrict_lot_moves
+        res = super(
+            StockMove, no_restrict_lot_moves
+        )._get_ordered_available_to_promise_by_warehouse(warehouse)
+        if not warehouse:
+            for move in restrict_lot_moves:
+                res[move] = {
+                    "ordered_available_to_promise_uom_qty": 0,
+                    "ordered_available_to_promise_qty": 0,
+                }
+            return res
+        location_domain = warehouse.view_location_id._get_available_to_promise_domain()
+        domain_quant = AND(
+            [[("lot_id", "in", self.restrict_lot_id.ids)], location_domain]
+        )
+        location_quants = self.env["stock.quant"].read_group(
+            domain_quant, ["lot_id", "quantity"], ["lot_id"], orderby="id"
+        )
+        quants_available = {
+            item["lot_id"][0]: item["quantity"] for item in location_quants
+        }
+        for move in restrict_lot_moves:
+            available_qty = quants_available.get(move.restrict_lot_id.id, 0.0)
+            res[move] = move._get_ordered_available_to_promise_qty(available_qty)
+        return res

stock_available_to_promise_release_restrict_lot/readme/CONTEXT.md

@@ -0,0 +1,14 @@
+When both `stock_available_to_promise_release` and `stock_restrict_lot` modules
+are installed, the calculation of quantities available to promise doesn't 
+properly account for lot restrictions. This results in a priority conflict, 
+where higher-priority moves that are restricted to a specific lot receive 
+available quantities from any lot, bypassing their lot restriction.
+
+The issue manifests as follows:
+- A move with a higher priority, restricted to a specific lot, is promised the available quantity regardless of lot constraints.
+- If the restricted lot is allocated to another move with lower priority, the lower-priority move can not be promised its designated lot.
+
+In effect, lot-restricted moves cannot accurately reserve quantities based on 
+both priority and specific lot requirements.
+This can lead to stock release issues, where low-priority moves fail to secure
+stock from their restricted lots due to incorrect available to promise calculations in higher-priority moves.

stock_available_to_promise_release_restrict_lot/readme/CONTRIBUTORS.md

@@ -0,0 +1 @@
+* Souheil Bejaoui <soueil.bejaoui@acsone.eu>

stock_available_to_promise_release_restrict_lot/readme/DESCRIPTION.md

@@ -0,0 +1,8 @@
+This module acts as an integration layer between `stock_available_to_promise_release`
+and `stock_restrict_lot`, enabling advanced stock allocation based on both
+available-to-promise quantities and lot restrictions.
+
+By combining available-to-promise logic with lot restriction functionality, 
+this module enhances stock move allocation by:
+- Allowing stock moves to respect both priority and specific lot allocations.
+- Ensuring that available quantities are promised according to move priority, but only when the lot matches the restriction.