-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0] Add stock_picking_type_shipping_policy - alpha #18
[13.0] Add stock_picking_type_shipping_policy - alpha #18
Conversation
320b342
to
f6139f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, just minor remarks
|
||
shipping_policy = fields.Selection( | ||
SHIPPING_POLICY_SELECTION, | ||
default=lambda r: r._default_shipping_policy(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need to split selection options to a var. You could delegate them to a method instead.
You don't need the default method but if you move options to a method then it's better if you keep it.
@@ -0,0 +1,2 @@ | |||
This module adds a Shipping Policy field on Operations Types in order to force | |||
a specific Shipping Policy on Pickings according to their types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth to mention the use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be:
This is especially useful if you use a pick-pack-ship setup with the release of operation (stock_available_to_promise_release) module along side with the stock_routing_operation that may split operations by zone of the warehouse. In that case, you want to be sure the pack operations will wait all different picks to be processed before releasing the availability of the pack operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM a part from my comments
@@ -0,0 +1,2 @@ | |||
This module adds a Shipping Policy field on Operations Types in order to force | |||
a specific Shipping Policy on Pickings according to their types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be:
This is especially useful if you use a pick-pack-ship setup with the release of operation (stock_available_to_promise_release) module along side with the stock_routing_operation that may split operations by zone of the warehouse. In that case, you want to be sure the pack operations will wait all different picks to be processed before releasing the availability of the pack operation.
/ocabot merge |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at e66f975. Thanks a lot for contributing to OCA. ❤️ |
backend: run tests as a stock user
This module adds a Shipping Policy field on Operations Types in order to force
a specific Shipping Policy on Pickings according to their types.