Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Add stock_picking_type_shipping_policy - alpha #18

Conversation

grindtildeath
Copy link
Contributor

This module adds a Shipping Policy field on Operations Types in order to force
a specific Shipping Policy on Pickings according to their types.

@grindtildeath grindtildeath changed the title Create module stock_picking_type_shipping_policy [12.0] Create module stock_picking_type_shipping_policy - alpha Mar 19, 2020
@grindtildeath grindtildeath changed the title [12.0] Create module stock_picking_type_shipping_policy - alpha [13.0] Create module stock_picking_type_shipping_policy - alpha Mar 19, 2020
@grindtildeath grindtildeath force-pushed the 13.0-add-stock_picking_type_shipping_policy branch from 320b342 to f6139f7 Compare March 19, 2020 16:01
@simahawk simahawk added this to the 13.0 milestone Mar 20, 2020
@simahawk simahawk changed the title [13.0] Create module stock_picking_type_shipping_policy - alpha [13.0] Add stock_picking_type_shipping_policy - alpha Mar 20, 2020
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just minor remarks


shipping_policy = fields.Selection(
SHIPPING_POLICY_SELECTION,
default=lambda r: r._default_shipping_policy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need to split selection options to a var. You could delegate them to a method instead.
You don't need the default method but if you move options to a method then it's better if you keep it.

@@ -0,0 +1,2 @@
This module adds a Shipping Policy field on Operations Types in order to force
a specific Shipping Policy on Pickings according to their types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth to mention the use case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be:

This is especially useful if you use a pick-pack-ship setup with the release of operation (stock_available_to_promise_release) module along side with the stock_routing_operation that may split operations by zone of the warehouse. In that case, you want to be sure the pack operations will wait all different picks to be processed before releasing the availability of the pack operation.

Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a part from my comments

@@ -0,0 +1,2 @@
This module adds a Shipping Policy field on Operations Types in order to force
a specific Shipping Policy on Pickings according to their types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be:

This is especially useful if you use a pick-pack-ship setup with the release of operation (stock_available_to_promise_release) module along side with the stock_routing_operation that may split operations by zone of the warehouse. In that case, you want to be sure the pack operations will wait all different picks to be processed before releasing the availability of the pack operation.

@simahawk
Copy link
Contributor

simahawk commented Apr 3, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-18-by-simahawk-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0b78809 into OCA:13.0 Apr 3, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e66f975. Thanks a lot for contributing to OCA. ❤️

sebalix pushed a commit to sebalix/wms that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants