New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] stock_release_channel_shipment_advice #560

Closed

sbejaoui wants to merge 10 commits into OCA:16.0 from acsone:16.0-stock_release_channel_shipment_advice-sbj

Contributor

sbejaoui commented Feb 7, 2023 •

edited

Loading

This module is used to plan the shipment advices for released pickings in a stock release channel.
As this is the base module, it only provides a simple planning mode. All the ready pickings of a release channel are grouped together to result in a single shipping advice per warehouse.

Depends on :

[16.0][ADD] shipment_advice_planner stock-logistics-transport#88

Contributor Author

sbejaoui commented Feb 7, 2023

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch 3 times, most recently from 9aa2dc2 to 345a177 Compare

February 7, 2023 14:55

lmignon suggested changes

View reviewed changes

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/views/stock_release_channel.xml Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Show resolved Hide resolved

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch 4 times, most recently from 59f1fc9 to b6362ab Compare

February 8, 2023 11:33

sbejaoui requested a review from lmignon

February 8, 2023 12:27

lmignon suggested changes

View reviewed changes

Contributor

lmignon left a comment

@sbejaoui The warehouse_id is not required on the release_channel but on the shipment_advice....

When you plan the shipments, you should group the picking by warehouse and makes a shipment advice by warehouse.

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch from b6362ab to 3ce9cef Compare

February 9, 2023 14:02

sbejaoui requested a review from lmignon

February 9, 2023 14:04

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch from 3ce9cef to bb53810 Compare

February 9, 2023 14:06

lmignon suggested changes

View reviewed changes

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch from ace622c to e5e45b6 Compare

February 9, 2023 17:28

sbejaoui requested a review from lmignon

February 9, 2023 17:29

lmignon suggested changes

View reviewed changes

Contributor

lmignon left a comment

nitpicking ....

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch 4 times, most recently from 9da01bc to bcb6b3a Compare

February 12, 2023 18:21

sbejaoui requested a review from lmignon

February 13, 2023 08:00

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch from bcb6b3a to 9952fdc Compare

February 13, 2023 10:07

lmignon reviewed

View reviewed changes

stock_release_channel_shipment_advice/models/shipment_advice_planner.py Outdated Show resolved Hide resolved

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch from 9952fdc to e0f8a70 Compare

February 13, 2023 14:40

sbejaoui requested a review from lmignon

February 13, 2023 14:40

lmignon suggested changes

View reviewed changes

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

sbejaoui requested a review from lmignon

February 13, 2023 14:41

lmignon suggested changes

View reviewed changes

stock_release_channel_shipment_advice/models/shipment_advice_planner.py Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/models/stock_release_channel.py Outdated Show resolved Hide resolved

jbaudoux reviewed

View reviewed changes

stock_release_channel_shipment_advice/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved

stock_release_channel_shipment_advice/readme/DESCRIPTION.rst Outdated

Comment on lines 4 to 5

		As this is the base module, it provides only a simple
		planning mode. All released pickings are grouped together in a single advice.

Contributor

jbaudoux Feb 17, 2023

Reading this, it is like all pickings inserted in the release channel are automatically planned in a shipment but I don't think so looking at the code.
Can you clarify how the shipment advice is supposed to be created in this simple mode and how the pickings are put in it?

Contributor Author

sbejaoui Feb 18, 2023 •

edited

Loading

I updated the description, please check my last commit and let me know

sbejaoui requested a review from jbaudoux

February 22, 2023 09:58

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch from f7a3523 to 4d466a3 Compare

February 22, 2023 10:03

jbaudoux approved these changes

View reviewed changes

OCA-git-bot added the approved label

sbejaoui mentioned this pull request

[16.0][ADD] - add stock_release_channel_shipment_advice_toursolver #577

Merged

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch 2 times, most recently from e8f5980 to 8aae49d Compare

June 19, 2023 08:15

sbejaoui and others added 9 commits

June 19, 2023 10:16


          [DO NOT MERGE] - add unmerged requirements

43efad4


          [16.0][ADD] - stock_release_channel_shipment_advice

8df4f19

This module is used to plan the  shipment advice for released pickings in a
stock release channel.

As this is the base module, it provides only a simple
planning mode. All released pickings are grouped together in a single advice.

fix label

Co-authored-by: Laurent Mignon (ACSONE) <laurent.mignon@acsone.eu>

[FIX] - button_show_shipment_advice: improve domain

Co-authored-by: Laurent Mignon (ACSONE) <laurent.mignon@acsone.eu>

[IMP] - _compute_can_plan_shipment: improve expression

Co-authored-by: Laurent Mignon (ACSONE) <laurent.mignon@acsone.eu>

[IMP] - _plan_shipment: improve expression

Co-authored-by: Laurent Mignon (ACSONE) <laurent.mignon@acsone.eu>

Apply suggestions from code review

Co-authored-by: Laurent Mignon (ACSONE) <laurent.mignon@acsone.eu>


          [IMP] - stock_release_channel_shipment_advice: add dock to release ch…

a4bfbf7

…annel

dock and warehouse are propgated from the release channel to shipment advice planner


          [IMP] - stock_release_channel_shipment_advice: check dock belong to t…

8cef28d

…he warehouse

add data validation + form behavior improvement


          [IMP] - stock_release_channel_shipment_advice: update description

9182bca


          [FIX] - fix method param

0535bdf


          [FIX] - use picking type warehouse to filter pickings to plan

5e94742


          [IMP] stock_release_channel_shipment_advice: Speedup compute of picki…

6e7e437

…ng_to_plan_ids


          [FIX] - fix compute picking_to_plan

83c33c8

self in compute is composed of objects browse(NewId), setting the computed field
with the db id leads to odoo raises and error saying newId didn't get a value

sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice-sbj branch from 8aae49d to 83c33c8 Compare

June 19, 2023 08:16


          [IMP] stock_release_channel_shipment_advice: Display tree view as def…

ad7b59e

…ault with Today filter

jbaudoux requested changes

View reviewed changes

stock_release_channel_shipment_advice/views/stock_release_channel.xml

+                                  attrs="{'invisible': [('can_plan_shipment', '=', False)]}"
+                              />
+                          </xpath>
+                          <xpath expr="//field[@name='warehouse_id']" position="after">

Contributor

jbaudoux Aug 18, 2023 •

edited

Loading

The Shipment Planning Method must be in the option tab, not in the selection criteria

Suggested change

      
                        <xpath expr="//field[@name='warehouse_id']" position="after">
          
                        <xpath expr="//group[@name='options']" position="inside">

Contributor

jbaudoux Aug 18, 2023

As commented below, as this is not the only field, maybe put that inside a new tab instead of putting it in options

OCA-git-bot removed the approved label

jbaudoux reviewed

View reviewed changes

stock_dynamic_routing/models/stock_routing_rule.py

@@ @@ -91,7 +91,6 @@ def _constrains_picking_type_location(self): @@
                               not record.location_dest_id
                               or not record.location_dest_id.is_sublocation_of(base_location)
                           ):

Contributor

jbaudoux Aug 18, 2023

Should not be part of this PR

jbaudoux reviewed

View reviewed changes

stock_release_channel_shipment_advice/views/stock_release_channel.xml

Comment on lines +36 to +41

+                          <xpath expr="//field[@name='warehouse_id']" position="after">
+                              <field
+                                  name="dock_id"
+                                  attrs="{'invisible': [('warehouse_id', '=', False)]}"
+                              />
+                          </xpath>

Contributor

jbaudoux Aug 18, 2023

Same for this. It should not be in the "Selection criteria" tab.

Maybe a new "shipment" tab would be suitable for the planning method and dock?

simahawk changed the title ~~[16.0][ADD] - stock_release_channel_shipment_advice~~ [16.0][ADD] stock_release_channel_shipment_advice

Contributor

simahawk commented Oct 6, 2023

I'm checking the build here

simahawk mentioned this pull request

[16.0][ADD] stock_release_channel_shipment_advice #761

Merged

Contributor

simahawk commented Oct 6, 2023

Moving fwd here #761

simahawk closed this

simahawk mentioned this pull request

[16.0][ADD] shipment_advice_planner OCA/stock-logistics-transport#106

Merged

lmignon deleted the 16.0-stock_release_channel_shipment_advice-sbj branch

February 21, 2024 16:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet