Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] stock_release_channel_shipment_advice_process_end_time #572

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Feb 15, 2023

This module allows to set a delay time (in minutes) between the release channel process end time and the shipment advice arrival to the dock time.

@sbejaoui sbejaoui changed the title [ADD] - add stock_release_channel_shipment_advice_process_end_time [16.0][ADD] - add stock_release_channel_shipment_advice_process_end_time Feb 15, 2023
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch 2 times, most recently from 1df3d83 to 59c7f4e Compare February 15, 2023 19:32
@sbejaoui
Copy link
Contributor Author

cc/ @lmignon

@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from 59c7f4e to 87189c9 Compare February 16, 2023 14:50
@sbejaoui sbejaoui requested a review from lmignon February 16, 2023 14:51
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbejaoui cosmetic changes are required to ensure a good UX

@sbejaoui sbejaoui requested a review from lmignon February 17, 2023 15:14
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch 2 times, most recently from 588030a to 1665bc6 Compare February 17, 2023 15:21
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from 1665bc6 to b98ca9d Compare February 17, 2023 16:43
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it simpler

@sbejaoui sbejaoui requested review from jbaudoux and lmignon and removed request for lmignon and jbaudoux February 17, 2023 17:40
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from 0b48027 to 90e8aeb Compare February 17, 2023 17:41
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from 90e8aeb to 0142c55 Compare February 20, 2023 08:33
@sbejaoui sbejaoui requested a review from jbaudoux February 20, 2023 08:33
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good now and much simpler :)

@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from 0142c55 to 49d513b Compare February 20, 2023 10:43
@simahawk simahawk changed the title [16.0][ADD] - add stock_release_channel_shipment_advice_process_end_time [16.0][ADD] stock_release_channel_shipment_advice_process_end_time Mar 10, 2023
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from d456d1c to 074fd09 Compare July 13, 2023 06:40
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from a5fe7f0 to 0ce6e05 Compare August 4, 2023 09:22
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 11, 2024
@lmignon lmignon force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch 2 times, most recently from 66051de to 1a6d292 Compare February 22, 2024 09:32
@jbaudoux
Copy link
Contributor

@lmignon All depends have been merged, you should drop the DON'T MERGE commit

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 25, 2024
@lmignon lmignon force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from 1a6d292 to ebab987 Compare March 11, 2024 10:33
@lmignon
Copy link
Contributor

lmignon commented Mar 11, 2024

@jbaudoux "DON'T MERGE" commit dropped.

@lmignon
Copy link
Contributor

lmignon commented Mar 12, 2024

@sbejaoui Can you fix this one?

This module allows to set a delay time (in minutes) between the release channel
process end time and the shipment advice arrival to the dock time.

[IMP] - rename delay field to shipment_advice_arrival_delay

[IMP] - keep delay config at warehouse level
@sbejaoui sbejaoui force-pushed the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch from ebab987 to 91e2188 Compare April 4, 2024 13:04
@sbejaoui
Copy link
Contributor Author

sbejaoui commented Apr 4, 2024

@sbejaoui Can you fix this one?

done

@jbaudoux
Copy link
Contributor

jbaudoux commented Apr 5, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-572-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fd861f2 into OCA:16.0 Apr 5, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d9fb84e. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-stock_release_channel_shipment_advice_process_end_time-sbj branch April 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants