-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_release_channel_shipment_advice_process_end_time #572
[16.0][ADD] stock_release_channel_shipment_advice_process_end_time #572
Conversation
1df3d83
to
59c7f4e
Compare
cc/ @lmignon |
stock_release_channel_shipment_advice_process_end_time/models/stock_release_channel.py
Outdated
Show resolved
Hide resolved
...advice_process_end_time/tests/test_stock_release_channel_shipment_advice_process_end_time.py
Outdated
Show resolved
Hide resolved
stock_release_channel_shipment_advice_process_end_time/views/stock_release_channel.xml
Outdated
Show resolved
Hide resolved
59c7f4e
to
87189c9
Compare
stock_release_channel_shipment_advice_process_end_time/models/res_company.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbejaoui cosmetic changes are required to ensure a good UX
stock_release_channel_shipment_advice_process_end_time/models/res_config_settings.py
Outdated
Show resolved
Hide resolved
stock_release_channel_shipment_advice_process_end_time/models/stock_release_channel.py
Outdated
Show resolved
Hide resolved
stock_release_channel_shipment_advice_process_end_time/models/stock_warehouse.py
Outdated
Show resolved
Hide resolved
stock_release_channel_shipment_advice_process_end_time/views/stock_release_channel.xml
Outdated
Show resolved
Hide resolved
588030a
to
1665bc6
Compare
stock_release_channel_shipment_advice_process_end_time/__manifest__.py
Outdated
Show resolved
Hide resolved
1665bc6
to
b98ca9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it simpler
stock_release_channel_shipment_advice_process_end_time/models/res_company.py
Outdated
Show resolved
Hide resolved
stock_release_channel_shipment_advice_process_end_time/models/stock_release_channel.py
Show resolved
Hide resolved
stock_release_channel_shipment_advice_process_end_time/models/stock_release_channel.py
Outdated
Show resolved
Hide resolved
0b48027
to
90e8aeb
Compare
stock_release_channel_shipment_advice_process_end_time/models/stock_release_channel.py
Outdated
Show resolved
Hide resolved
stock_release_channel_shipment_advice_process_end_time/readme/USAGE.rst
Outdated
Show resolved
Hide resolved
90e8aeb
to
0142c55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good now and much simpler :)
0142c55
to
49d513b
Compare
d456d1c
to
074fd09
Compare
a5fe7f0
to
0ce6e05
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
66051de
to
1a6d292
Compare
@lmignon All depends have been merged, you should drop the DON'T MERGE commit |
1a6d292
to
ebab987
Compare
@jbaudoux "DON'T MERGE" commit dropped. |
@sbejaoui Can you fix this one? |
This module allows to set a delay time (in minutes) between the release channel process end time and the shipment advice arrival to the dock time. [IMP] - rename delay field to shipment_advice_arrival_delay [IMP] - keep delay config at warehouse level
ebab987
to
91e2188
Compare
done |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at d9fb84e. Thanks a lot for contributing to OCA. ❤️ |
This module allows to set a delay time (in minutes) between the release channel process end time and the shipment advice arrival to the dock time.