Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] delivery_carrier_warehouse #800

Merged
merged 17 commits into from
Dec 8, 2023

Conversation

santostelmo
Copy link
Contributor

delivery_carrier_warehouse Migration to 16.0

@santostelmo santostelmo force-pushed the 16.0-mig-delivery_carrier_warehouse branch from 54ebed5 to 07bb4b8 Compare December 7, 2023 09:44
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xmlid has been renamed in delivery demo data

cls.partner = ref("base.res_partner_12")
cls.product = ref("product.product_product_20")
cls.free_delivery_carrier = ref("delivery.free_delivery_carrier")
cls.normal_delivery_carrier = ref("delivery.normal_delivery_carrier")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cls.normal_delivery_carrier = ref("delivery.normal_delivery_carrier")
cls.local_delivery_carrier = ref("delivery.delivery_local_delivery")

def test_warehouse_carrier(self):
order = self._create_sale_order()
self.assertEqual(
self.partner.property_delivery_carrier_id, self.normal_delivery_carrier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.partner.property_delivery_carrier_id, self.normal_delivery_carrier
self.partner.property_delivery_carrier_id, self.local_delivery_carrier

)
action = order.action_open_delivery_wizard()
default_carrier_id = action["context"]["default_carrier_id"]
self.assertEqual(default_carrier_id, self.normal_delivery_carrier.id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.assertEqual(default_carrier_id, self.normal_delivery_carrier.id)
self.assertEqual(default_carrier_id, self.local_delivery_carrier.id)

@santostelmo santostelmo force-pushed the 16.0-mig-delivery_carrier_warehouse branch from 3505e03 to 54fb820 Compare December 8, 2023 11:46
Copy link
Contributor

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaudoux
Copy link
Contributor

jbaudoux commented Dec 8, 2023

/ocabot migration delivery_carrier_warehouse

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 8, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 7, 2023
18 tasks
@jbaudoux
Copy link
Contributor

jbaudoux commented Dec 8, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-800-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 372f6b2 into OCA:16.0 Dec 8, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 167015a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.