[14.0][IMP] shopfloor, stock_picking_partner_note: display picking info notes in cluster_picking and checkout scenarios

[JuMiSanAr]

Depends on:

• [14.0][MIG] stock_picking_partner_note: Migration from 16 to 14.0 stock-logistics-workflow#1504

Stock picking partner notes are notes that are pre-defined for each customer
and can be displayed for each picking.
With this PR, we send them to the frontend for the cluster picking scenario and display them where needed.

This PR also deprecated shopfloor_packing_info in favor of stock_picking_partner_note, which is now used for both checkout and cluster picking.

ref: cos-4214

[jbaudoux]

I think you better deprecate this module and update shppfloor to send the picking note to the front and display it in the front
You don't need to depend on stock_picking_partner_note as this is just populating the note on the picking

[JuMiSanAr]

I think you better deprecate this module and update shppfloor to send the picking note to the front and display it in the front You don't need to depend on stock_picking_partner_note as this is just populating the note on the picking

@jbaudoux
Ok, I've added a note in de DESCRIPTION.rst file in shopfloor_packing_note (let me know if there's a better way to mark a module as deprecated) and I've also pushed to this PR a new shopfloor_stock_picking_partner_note module. Let me know if it looks ok to you.

[JuMiSanAr]

@jbaudoux I've updated the module with your remarks, but now I'm wondering: will the notes be correctly recomputed each time we change the partner? Because the field introduced in stock_picking_partner_note is stored...

[jbaudoux]

@jbaudoux I've updated the module with your remarks, but now I'm wondering: will the notes be correctly recomputed each time we change the partner? Because the field introduced in stock_picking_partner_note is stored...

Yes, there is a depends on partner: https://github.com/OCA/stock-logistics-workflow/pull/1504/files#diff-9ec7eee25885dbe0455eef41843ed79f5fbfd8c8579b90c09f05754ee93fef2cR13

[jbaudoux]

I don't see the display of the note in the zone picking

[JuMiSanAr]

I don't see the display of the note in the zone picking

The task descriptions says it's not applicable for zone picking right?

"In shopfloor cluster picking (n.a. for zone picking), display the respective picking info..."

[simahawk]

LG overall but the mig step and the dep.

[jbaudoux]

More feature with less code, isn't it wonderful !

Please split last commit. One commit for shopfloor, and one for shopfloor_mobile

[simahawk]

@JuMiSanAr can you rebase?

[JuMiSanAr]

Failing tests should be fixed with:
OCA/stock-logistics-workflow#1543

[rousseldenis]

@JuMiSanAr Don't forget to have a meaningful PR's description. It should at least mention the module you modify in order to help reviewing. Thanks

[simahawk]

[JuMiSanAr]

This test fails because we depend on stock_picking_partner_note, which currently has note as an Html field. As soon as we merge OCA/stock-logistics-workflow#1543 (review) , the test should pass.

[simahawk]

This test fails because we depend on stock_picking_partner_note, which currently has note as an Html field. As soon as we merge OCA/stock-logistics-workflow#1543 (review) , the test should pass.

Then you should add that PR as a tmp test req :wink

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.