[16.0][IMP] sale_stock_available_to_promise_release mto availability_status #903
Conversation
santostelmo
changed the title
sale_stock_available_to_promise_release/models/sale_order_line.py
Outdated
Show resolved
Hide resolved
But then if you have a unavailable mto product, you end up with restock status. It should be |
sale_stock_available_to_promise_release/models/sale_order_line.py
Outdated
Show resolved
Hide resolved
You're right. Then drop the misplaced comment :) |
santostelmo
force-pushed
the
16.0-imp-sale_stock_available_to_promise_release-mto-availability_status
branch
from
92996c6
to
1f6901b
Compare
|
@sebalix @mmequignon We did this change. Ok for you ? |
| # On order product | ||
| elif self.is_mto: | ||
| availability_status = "on_order" |
There was a problem hiding this comment.
shouldn't this be checked first ?
We might have MTO sale order lines availability status set to partial here.
There was a problem hiding this comment.
It depends what we want to show to the user first. I would show 1st partial (we are able to deliver some qty), 2nd on_order ( we have no quantity available and need to fully order it)
There was a problem hiding this comment.
If mto, it's on order, period, whether you have stock or not.
There was a problem hiding this comment.
If user wants smth else, he changes the route on the so line, and that's it.
There was a problem hiding this comment.
Sale person wants to know if product is available to ship or if action is required to order it. Otherwise this status is useless for him.
There was a problem hiding this comment.
If you want to display availability, then product shouldn't be MTO.
@jbaudoux @santostelmo can we discuss this ? I'm not sure to understand what we're solving here...
There was a problem hiding this comment.
@mmequignon For standard MTO products, it's on order when SO is draft but the status will update when the product is received and available.
Also, in case of MTO as MTS (MTO route that generates an orderpoint with min/max=0), then if you have stock because someone returned an MTO product, then you see if it is available when placing the SO
|
@mmequignon good for you? |
|
This PR has the |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
sebalix
removed
the
stale
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at a0c4741. Thanks a lot for contributing to OCA. ❤️ |
sebalix
deleted the
16.0-imp-sale_stock_available_to_promise_release-mto-availability_status
branch
When stock becomes available for
is_mtoproduct,, sale order line availability status should reflect that status.Currently nothing happens in that circumstances as the status always stays in
on_ordereven if there's stock available.Also standard is already providing a computed field
is_mto=>_on_order_routecan be dropped.