Support for editing config file (to an extent) via web dashboard #49
Conversation
There was a problem hiding this comment.
Sorry, missed this when reviewing... GBT cURL call has an aggressive timeout so that the block template thread never hangs.
Booting all stratum clients after a single failure is probably too aggressive, considering the 1 second retry already in play. Any number of benign things can prevent this call from returning, especially if the node isn't on the same machine.
If we are working on something valid, I'd suggest not booting stratum clients until GBT fails for long enough for the the current job to be stale.
|
Is there anything in this patch, or elsewhere, that adds access control for the dashboard? AFAIK, that has to be done external to datum_gateway itself right now, but it's not too much of a threat to just display the stats. Adding config editing changes that. |
|
@szarka This feature is disabled by default and needs to be turned on with a new config file setting. Currently, it does not have any special access control, and that could be a possible follow-up PR. Note that it intentionally does not "read back" the RPC password, only allows changing it. |
Nice. 👍 |
|
Let's add authentication to this. Should require (or least give the user the option of requiring) username/password to log in to the dashboard. |
|
Not sure authentication is realistic: right now, the webserver is entirely unencrypted and can just be MITM'd... |
Built on top of #25
Mostly functional, two FIXMEs remain that should have minimal issues until followup. Would be nice to avoid restarting ever, but that can be a future improvement.