Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Use virtual environment #1008

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Mar 15, 2023

python3-pip can now be removed, and running pip instead of pip3 is sufficient.

This also avoids the installation of python3-setuptools and python3-wheel (requirements of python3-pip).

python3-pip can now be removed, and running pip instead of pip3 is sufficient.

This also avoids the installation of python3-setuptools and python3-wheel
(requirements of python3-pip).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree in principle but will release it separately tomorrow.

@kba kba requested a review from bertsky March 22, 2023 17:14
@kba kba merged commit 209fa21 into OCR-D:master Jun 7, 2023
@stweil stweil deleted the fix-dockerfile branch June 20, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants