Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow extension #1143

Merged
merged 12 commits into from
Nov 27, 2023
Merged

Workflow extension #1143

merged 12 commits into from
Nov 27, 2023

Conversation

joschrew
Copy link
Contributor

Change the two existing workflow paths to run a workflow and to query a workflow job.
Add endpoints for uploading, updating and downloading a workflow script. The scripts are stored in the mongodb.
Workflows can be run with a previously uploaded script or with providing a script when starting the workflow.

@joschrew joschrew requested review from kba and MehmedGIT November 21, 2023 14:36
@joschrew joschrew changed the base branch from master to network-processor-api November 21, 2023 14:38
Base automatically changed from network-processor-api to master November 21, 2023 14:41
@MehmedGIT
Copy link
Contributor

Looks good - just the failing test needs to be fixed.

Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not yet tested though.

ocrd_network/ocrd_network/processing_server.py Outdated Show resolved Hide resolved
ocrd_network/ocrd_network/utils.py Outdated Show resolved Hide resolved
ocrd_network/ocrd_network/utils.py Outdated Show resolved Hide resolved
@kba
Copy link
Member

kba commented Nov 21, 2023

ocrd_network/ocrd_network/models/workflow.py seems missing - forgot to commit @joschrew?

@joschrew
Copy link
Contributor Author

joschrew commented Nov 21, 2023

thx, that explains the test error I am currently looking into / trying to find. Not the first time this happens to me ...

@MehmedGIT MehmedGIT self-requested a review November 23, 2023 13:56
@kba kba merged commit 01f3594 into master Nov 27, 2023
@kba kba deleted the network-workflow-api branch November 27, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants