PageType.get_AllRegions to list all kinds of regions #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 80.10% 80.02% -0.09%
==========================================
Files 40 40
Lines 2388 2393 +5
Branches 442 444 +2
==========================================
+ Hits 1913 1915 +2
- Misses 403 406 +3
Partials 72 72
Continue to review full report at Codecov.
|
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
bertsky
reviewed
May 14, 2020
…to get-all-regions
…rder=reading-order
bertsky
requested changes
May 18, 2020
bertsky
requested changes
May 18, 2020
bertsky
reviewed
May 19, 2020
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 79.71% 79.62% -0.10%
==========================================
Files 41 41
Lines 2490 2493 +3
Branches 477 478 +1
==========================================
Hits 1985 1985
- Misses 417 420 +3
Partials 88 88
Continue to review full report at Codecov.
|
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
bertsky
reviewed
May 28, 2020
bertsky
reviewed
May 28, 2020
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
bertsky
approved these changes
May 28, 2020
bertsky
approved these changes
May 29, 2020
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
…oupIndexed properly
bertsky
approved these changes
Jun 2, 2020
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step to have a type-agnostic listing of all Regions, Text-, Table-, Graphics- etc.
Currently only available on the
Pageelement,ordering by reading order not yet implemeneted.Is now implemented.#240 (comment)
Since we've been adding a few methods to the generateDS code now, I've refactored the code so that the methods can be defined in their own file with proper syntax highlighting etc..