resmgr download: separate name and url #792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefine `download` command to allow setting a `name` for arbitrary (unregistered) URLs, or overriding URLs for existing (registered) names. Change `-n` / `--any-url` from a flag to an option, change `URL_OR_NAME` to pure `NAME`. Simplify implementation.
|
We should add a test for the |
- `Processor`: add `module` and `moduledir` property - `Processor.__init__`: delegate to `self.list_all_resources` for `-L` - `Processor.__init__`: delegate to `self.resolve_resource` for `-C` - `Processor.list_all_resources`: pass moduledir for additional candidates, revise filter criterion (solely based on MIME type, and strictly matching filename suffixes - unless any MIME is unknown) - `Processor.resolve_resource`: pass moduledir for additional candidates - `ocrd_utils.get_processor_resource_types`: show MIME types instead of just directory vs file (with `*/*` as fall-back) - `OcrdResourceManager.list_installed`: adapt (MIME type, but not enforcing suffixes; no moduledir)
…dir (bashlib processors)
kba
approved these changes
Feb 9, 2022
|
Note: this warrants a new minor release, because the Documentation will have to be updated in various places:
|
Closed
|
Merged into #800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780