Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocrdzip #312

Closed
wants to merge 3 commits into from
Closed

Ocrdzip #312

wants to merge 3 commits into from

Conversation

joschrew
Copy link
Contributor

Hi, this is my first pull request ever. Unfortunately I am not able to fix the error I actually wanted to fix: In an OCRD-ZIP the BagIt-Profile-Identifier must be the string https://ocr-d.de/bagit-profile.json. But latter URL is not available, getting 404 instead. I'm not sure but I think this is an error and the file should be available. But I'd need help to fix this.
While reading the rest of the ocrd-zip-docu I found another minor issue and another one while trying to figure out (reading readme.md) how to build and test the website. That's why I decided to try this pull request.

@kba
Copy link
Member

kba commented Apr 26, 2022

Thanks for the PR!

The fix in README is fine as-is.

The fix to the ocrd_zip spec should be done in the spec repo by adapting https://github.com/OCR-D/spec/blob/master/ocrd_zip.md. Otherwise, your change will be overwritten next time we deploy the specs to the website.

In an OCRD-ZIP the BagIt-Profile-Identifier must be the string https://ocr-d.de/bagit-profile.json. But latter URL is not available, getting 404 instead.

Good catch, I missed that when we switched our website over to GH pages. Before that switch, the specs were deployed to ocr-d.github.io directly, now they are in a subdirectory /en/spec and do not contain the JSON schemas, bagit profile or OpenAPI definitions. I will fix that separately in another PR.

@joschrew
Copy link
Contributor Author

moved spec fix to: OCR-D/spec#203

@joschrew joschrew closed this May 3, 2022
@kba
Copy link
Member

kba commented May 3, 2022

I've cherry-picked the commit fixing the typo in README d6c7a55 to master. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants