Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify file iterator by delegating to bashlib input-files #82

Merged
merged 2 commits into from
Dec 8, 2021
Merged

simplify file iterator by delegating to bashlib input-files #82

merged 2 commits into from
Dec 8, 2021

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Dec 2, 2021

Depends on OCR-D/core#753

Opens the path for a fix for #77

@bertsky bertsky linked an issue Dec 2, 2021 that may be closed by this pull request
Do not create or remove folder if no input images #75
Closed
@bertsky
Copy link
Collaborator Author

bertsky commented Dec 2, 2021

CI:

ERROR: ocrd/core is too old (2.28.0 < 2.29.0). Please update OCR-D/core

this is expected. We have to wait for the update in core.

@bertsky
Copy link
Collaborator Author

bertsky commented Dec 8, 2021

Rerunning CI 🤞

@bertsky bertsky requested a review from kba December 8, 2021 11:53
kba
kba approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an improvement in readability and robustness 👍 Great work, also on the core release that enables it.

@bertsky
Copy link
Collaborator Author

bertsky commented Dec 8, 2021

Thanks – next I'll apply the same recipe to the other bashlib modules one by one.

@bertsky bertsky merged commit 9117389 into OCR-D:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not create or remove folder if no input images
2 participants
@bertsky @kba