Skip to content

Commit

Permalink
.
Browse files Browse the repository at this point in the history
  • Loading branch information
@kba
kba committed Jun 17, 2019
1 parent bb00785 commit 3341d8e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .circleci/config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ jobs:
- image: ubuntu:18.04
steps:
- checkout
- run: make deps-ubuntu deps-test deps install repo/assets
- run: make test
- run: apt-get update ; apt-get install -y sudo make python3 python3-pip git
- run: make deps-ubuntu deps-test deps install repo/assets PIP=pip3
- run: make test PYTHON=python3

workflows:
version: 2
Expand Down

2 comments on commit 3341d8e

@bertsky
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kba This looks like we should really change Makefile instead of changing the CI config. We could have apt-get update && apt-get install -y sudo make python3 python3-pip git as the first line of the deps-ubuntu recipe, and change the variable defaults PYTHON and PIP to version 3.

@kba
Copy link
Member Author

@kba kba commented on 3341d8e Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to have the install cmds in one place, you're right.

The defaults were left open to support python2. Since we don't have to do that anymore, we can change the defaults.

I will do that, thanks.

Please sign in to comment.