Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segment-line: validate intersection with parent #120

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Mar 5, 2020

Fix #119

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #120 into master will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   37.46%   37.03%   -0.43%     
==========================================
  Files           9        9              
  Lines         953      964      +11     
  Branches      209      214       +5     
==========================================
  Hits          357      357              
- Misses        532      543      +11     
  Partials       64       64              
Impacted Files Coverage Δ
ocrd_tesserocr/segment_line.py 60.52% <0.00%> (-10.25%) ⬇️
ocrd_tesserocr/segment_table.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7026429...a6659f0. Read the comment docs.

@wrznr
Copy link
Contributor

wrznr commented Mar 9, 2020

@bertsky Can we merge this?

@bertsky
Copy link
Collaborator Author

bertsky commented Mar 9, 2020

Can we merge this?

If you have tested on your dataset to satisfaction, then yes. (As I said, I was not able to come up with enough tests myself.)

@bertsky
Copy link
Collaborator Author

bertsky commented Mar 30, 2020

Can we merge this?

If you have tested on your dataset to satisfaction, then yes. (As I said, I was not able to come up with enough tests myself.)

@wrznr have you tested this on your real-life dataset yet?

@bertsky bertsky merged commit f11c111 into OCR-D:master Apr 8, 2020
@bertsky bertsky deleted the fix-segment-line-hull branch April 8, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"segment-line" produces "GeometryCollection" (which has no coords)
3 participants