CI: test-cli, drop sudo, default to python3/pip3 #45

kba · 2019-06-18T11:37:32Z

No description provided.

bertsky

Thanks for moving on with this!

.circleci/config.yml

Makefile

.circleci/config.yml

kba · 2019-06-25T13:05:14Z

Maybe we can move the shell exports into ocrd/core and ocrd/tesserocr dockerfiles in a separate PR?

That's a good idea. Gotta spend some time on our docker setup in 2019/07. Issue and/or PR appreciated.

bertsky · 2019-06-25T13:29:22Z

That's a good idea. Gotta spend some time on our docker setup in 2019/07. Issue and/or PR appreciated.

Sorry, my mistake: they both already contain

ENV LC_ALL C.UTF-8
ENV LANG C.UTF-8

(It's only required here in circlici where we use vanilla ubuntu:18.04)

kba added 5 commits June 17, 2019 19:57

circleci: make test-cli

c6edcc9

drop sudo, fix #43

94adb11

makefile: drop dep on xmllint/exiftool

12d2e2b

makefile: install git, python, pip

118fffa

make test-cli: test the cli scripts

6c91f38

kba requested a review from bertsky June 18, 2019 11:38

bertsky requested changes Jun 18, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

Makefile Show resolved Hide resolved

kba force-pushed the ci-cli branch from a2defa5 to 99a3b26 Compare June 18, 2019 15:23

bertsky requested changes Jun 18, 2019

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

💚 checkout after installing git for circleci-cli local

0da09dd

kba force-pushed the ci-cli branch from 99a3b26 to 0da09dd Compare June 18, 2019 15:31

bertsky self-requested a review June 25, 2019 12:50

bertsky approved these changes Jun 25, 2019

View reviewed changes

kba merged commit 7b67a44 into master Jun 25, 2019

kba deleted the ci-cli branch June 25, 2019 13:06

Provide feedback