Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change structure of mets.md #155

Closed
wants to merge 1 commit into from

Conversation

tboenig
Copy link
Contributor

@tboenig tboenig commented Jun 3, 2020

add structMap (fix #142 ).see #154 for that

Changes the document structure

@tboenig tboenig requested a review from wrznr June 4, 2020 11:06
@kba kba force-pushed the add_structmap_and_new_doc_structur_order branch from e05d461 to 22b4bcf Compare June 7, 2020 12:54
@kba kba changed the title Update mets.md with fix #142 Change structure of mets.md Jun 7, 2020
@cneud
Copy link
Member

cneud commented Feb 4, 2021

This is already published - and probably has been for a while - so I assume we can close? @tboenig

@bertsky
Copy link
Collaborator

bertsky commented Feb 4, 2021

This is already published - and probably has been for a while - so I assume we can close?

Huh? This PR has not been applied, neither on the website nor in master.

But (apart from the required update/resolution) I don't think we want that change:

@tboenig please explain your rationale! (Also, mind that #154 still needs to be worked upon.

(If my judgement is correct, than this should be closed, and once #154 is done, a new PR can move sections around.)

@cneud
Copy link
Member

cneud commented Feb 4, 2021

sorry @bertsky I was trying to go through what appeared like staled issues but apparently I've only scratched the surcface of the iceberg. I'll see what I can do to help with #154 then.

@cneud
Copy link
Member

cneud commented Feb 4, 2021

(If my judgement is correct, than this should be closed, and once #154 is done, a new PR can move sections around.)

Having looked at #154, I agree. Let's close this and complete #154, resulting changes should be implemented either there or in a new PR.

@EEngl52
Copy link

EEngl52 commented May 20, 2021

@tboenig can we close this PR and move forward with #154 ?

@kba
Copy link
Member

kba commented Aug 2, 2022

Superseded by #207

@kba kba closed this Aug 2, 2022
@kba kba deleted the add_structmap_and_new_doc_structur_order branch September 6, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow global fptrs in structMap
5 participants