Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocrd-tool: require content-type=text/directory for directory parameters #189

Merged
merged 4 commits into from
Jan 30, 2022
Merged

ocrd-tool: require content-type=text/directory for directory parameters #189

merged 4 commits into from
Jan 30, 2022

Conversation

kba
Copy link
Member

@kba kba commented Dec 22, 2021

See OCR-D/core#750 for discussion.

Tangentially related: OCR-D/core#691

@bertsky
Copy link
Collaborator

bertsky commented Dec 22, 2021

Note: what I meant by…

But then, why not just use content-type: text/directory or format: directory?

…was to use the existing parameters/properties content-type or format.

@kba kba mentioned this pull request Dec 22, 2021
Closed
bertsky
bertsky reviewed Dec 22, 2021
View reviewed changes
ocrd_tool.schema.yml Outdated Show resolved Hide resolved
ocrd_tool.schema.yml Outdated Show resolved Hide resolved
@kba @bertsky
ocrd_tool: content-type fix typos
114c65c 
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
@bertsky bertsky changed the title ocrd-tool: introduce resource-content-type tool property ocrd-tool: require content-type=text/directory for directory parameters Dec 23, 2021
@kba kba merged commit c2dd1ad into master Jan 30, 2022
@kba kba deleted the resource-file-folder branch September 6, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertsky bertsky bertsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kba @bertsky