Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change content-type GET workflow/{workflow-id} according to POST /workflow #223

Merged
merged 1 commit into from
Nov 30, 2022
Merged

change content-type GET workflow/{workflow-id} according to POST /workflow #223

merged 1 commit into from
Nov 30, 2022

Conversation

joschrew
Copy link
Contributor

@joschrew joschrew commented Aug 23, 2022

In POST /workflow (upload a workflow-script) the content-type is text/vnd.ocrd.workflow. Because of that I think the content type to get back a workflow must be the same and not application/vnd.ocrd+zip.

@joschrew
Copy link
Contributor Author

joschrew commented Oct 28, 2022

Reminder (rather for myself) to know what I mean:
POST /workflow is used to upload a workflow. There the content-type for the request body is text/vnd.ocrd.workflow. I assume this is right.
GET /workflow/{workflow-id} us used to retrieve a workflow. There the content-type of the response is currently application/vnd.ocrd+zip. But it returns a workflow and not a workspace so I think the content-type has to be changed to one mentioned before. I think this is just a copy-and-paste leftover, where the creator forgot to change the type of the response.

@kba kba merged commit 8dbe9ed into OCR-D:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants