-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fileGrp cardinality to ocrd-tool.json schema, deprecate fileGrp names #255
Conversation
@kba I believe I made a mistake in JSON Schema's For our simple test JSON … {
"git_url": "https://github.com/ocr-d/foo",
"version": "0.0.1",
"tools": {
"ocrd-xyz": {
"executable": "ocrd-xyz",
"description": "bars all the foos",
"input_file_grp_cardinality": 1,
"output_file_grp_cardinality": 1,
"categories": ["Layout analysis"],
"steps": ["layout/analysis"]
}
}
} …the CI in core now yields this invalidity:
So it seems that the list/array syntax got lost... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah got it – many thanks!
Co-authored-by: Konstantin Baierer <kba@users.noreply.github.com>
Co-authored-by: Konstantin Baierer <kba@users.noreply.github.com>
I updated this in OCR-D/core#1240 – let's hope CI works now |
GHA Actions tests, pass, I've manually started CircleCI again https://app.circleci.com/pipelines/github/OCR-D/core/2692/workflows/ac341a28-e2e0-45aa-ab00-9d56aa58eb0a Once that passes, I'll merge and release new spec version. |
No description provided.