Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version number for binary releases #1131

Closed
Armael opened this issue May 21, 2024 · 2 comments · Fixed by #1171
Closed

version number for binary releases #1131

Armael opened this issue May 21, 2024 · 2 comments · Fixed by #1171
Assignees
@bclement-ocp
Milestone
2.6.0

Comments

@Armael
Copy link

Armael commented May 21, 2024

There seems to be an issue with how binary releases are produced, in that the --version they return is the hash of the corresponding git commit, instead of a version number.
This is problematic because :

  • it is not consistent with binaries produced when installing alt-ergo through opam
  • it makes why3 fail to detect the alt-ergo version (since why3 is expecting --version to behave as it does for opam-built releases)
@bclement-ocp bclement-ocp self-assigned this May 21, 2024
@Armael Armael mentioned this issue Jun 3, 2024
Open
4 tasks
@bclement-ocp bclement-ocp added this to the 2.6.0 milestone Jul 11, 2024
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this issue Jul 22, 2024
@bclement-ocp
fix(CI): Ensure binary releases have proper version number
5f4cf9d 
The issue boils down to GitHub not downloading tag information when
running the workflow, which means that `dune-build-info` and
`dune-subst` see a lightweight tag rather than an annotated tag and
ignore it.

In order to facilitate deployment, update the workflow to automatically
upload the artifact to the release if applicable.

Fixes OCamlPro#1131
@bclement-ocp bclement-ocp mentioned this issue Jul 22, 2024
Merged
Halbaroth pushed a commit that referenced this issue Jul 22, 2024
@bclement-ocp
fix(CI): Ensure binary releases have proper version number (#1171)
15e4a50 
The issue boils down to GitHub not downloading tag information when
running the workflow, which means that `dune-build-info` and
`dune-subst` see a lightweight tag rather than an annotated tag and
ignore it.

In order to facilitate deployment, update the workflow to automatically
upload the artifact to the release if applicable.

Fixes #1131
Halbaroth pushed a commit to Halbaroth/alt-ergo that referenced this issue Jul 24, 2024
@bclement-ocp @Halbaroth
fix(CI): Ensure binary releases have proper version number (OCamlPro#…
4e87553 
…1171)

The issue boils down to GitHub not downloading tag information when
running the workflow, which means that `dune-build-info` and
`dune-subst` see a lightweight tag rather than an annotated tag and
ignore it.

In order to facilitate deployment, update the workflow to automatically
upload the artifact to the release if applicable.

Fixes OCamlPro#1131
bclement-ocp added a commit that referenced this issue Aug 29, 2024
@bclement-ocp
fix(CI): Ensure binary releases have proper version number (#1171)
78ba9cc 
The issue boils down to GitHub not downloading tag information when
running the workflow, which means that `dune-build-info` and
`dune-subst` see a lightweight tag rather than an annotated tag and
ignore it.

In order to facilitate deployment, update the workflow to automatically
upload the artifact to the release if applicable.

Fixes #1131
@bclement-ocp
Copy link
Collaborator

Looks like this no longer works somehow? Re-opening; need to investigate before 2.6 release.

@bclement-ocp bclement-ocp reopened this Aug 29, 2024
@bclement-ocp
Copy link
Collaborator

Actually it works but not if the release is created by GitHub UI (sigh).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclement-ocp bclement-ocp

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

fix(CI): Ensure binary releases have proper version number bclement-ocp/alt-ergo
2 participants
@Armael @bclement-ocp