Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imperative API for FunSAT #899

Closed
Halbaroth opened this issue Oct 18, 2023 · 0 comments · Fixed by #962
Closed

Imperative API for FunSAT #899

Halbaroth opened this issue Oct 18, 2023 · 0 comments · Fixed by #962
Assignees
@Stevendeo @bclement-ocp
Labels
clean-up refactoring

Comments

@Halbaroth
Copy link
Collaborator

The FunSAT solver exposes a purely functional API which isn't convenient while executing a SMT-LIB script. Exposing a new imperative API simplify a lot the Frontend module.

The frontend satml_frontend exposes the same functional API built on the top of an imperative one... We may only expose an imperative API for all the SAT solvers and the current functional one of FunSAT will be an internal API only.
@bclement-ocp bclement-ocp mentioned this issue Nov 8, 2023
Merged
@Stevendeo Stevendeo self-assigned this Nov 21, 2023
This was referenced Nov 21, 2023
Merged
Merged
@bclement-ocp bclement-ocp linked a pull request Nov 23, 2023 that will close this issue
Imperative API #962
Merged
bclement-ocp pushed a commit that referenced this issue Nov 23, 2023
@Stevendeo
Imperative API (#962)
201957e 
Tackles #899 by making both Sat API imperative.

    The imperative is made... well, imperative; it still relies on Satml_frontend for properly wrapping calls to Satml. We should be able to merge them, but I choosed not to in this PR to avoid spaghettification.
    The functional sat now has an imperative frontend upadting a reference to the environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stevendeo Stevendeo

@bclement-ocp bclement-ocp

Labels
clean-up refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Imperative API Stevendeo/alt-ergo
3 participants
@Halbaroth @Stevendeo @bclement-ocp