Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BV): Only store domains on variable parts #1152

Merged
merged 15 commits into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
### Theory reasoning

- Add word-level propagators for the BV theory (#944, #1004, #1007, #1010,
#1011, #1012, #1040, #1044, #1054, #1055, #1056, #1057, #1065, #1073, #1144)
#1011, #1012, #1040, #1044, #1054, #1055, #1056, #1057, #1065, #1073, #1144,
#1152)
- Add interval domains and arithmetic propagators for the BV theory (#1058,
#1083, #1084, #1085)
- Fix incompleteness issues in the BV solver (#978, #979)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dune
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
Instances IntervalCalculus Intervals_intf Intervals_core Intervals
Ite_rel Matching Matching_types Polynome Records Records_rel
Satml_frontend_hybrid Satml_frontend Satml Sat_solver Sat_solver_sig
Sig Sig_rel Theory Uf Use Rel_utils Bitlist
Sig Sig_rel Theory Uf Use Domains Domains_intf Rel_utils Bitlist
; structures
Commands Errors Explanation Fpa_rounding
Parsed Profiling Satml_types Symbols
Expand Down
6 changes: 3 additions & 3 deletions src/lib/reasoners/adt_rel.ml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ module Domains = struct
with Not_found ->
Domain.unknown (X.type_info r)

let add r t =
let init r t =
match Th.embed r with
| Alien _ when not (MX.mem r t.domains) ->
(* We have to add a default domain if the key `r` is not in map in order
Expand Down Expand Up @@ -243,7 +243,7 @@ module Domains = struct
let t = remove r t in
tighten nr nd t

| exception Not_found -> add nr t
| exception Not_found -> init nr t

(* [propagate f a t] iterates on all the changed domains of [t] since the
last call of [propagate]. The list of changed domains is flushed after
Expand Down Expand Up @@ -438,7 +438,7 @@ let add r uf domains =
| Ty.Tadt _ ->
Debug.add r;
let rr, _ = Uf.find_r uf r in
Domains.add rr domains
Domains.init rr domains
| _ ->
domains

Expand Down
Loading
Loading