Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #518

Merged
merged 11 commits into from
Sep 20, 2022
Merged

Fix CI #518

merged 11 commits into from
Sep 20, 2022

Conversation

Stevendeo
Copy link
Collaborator

No description provided.

@Stevendeo Stevendeo changed the title Fix CI Draft: Fix CI Jul 11, 2022
Copy link
Collaborator

@Gbury Gbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the exact motivation for this PR ?

@@ -26,6 +30,9 @@ jobs:
# to `ocaml` with the container parameters
- run: sudo chmod a+wx .

- name: Reclaim cache directory
run: sudo chown -R 1001:1001 .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what kind of problem does that fix ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker image build fails ; right now the error is Error: EACCES: permission denied, mkdir '/__w/_temp/9c8f979e-f394-49cf-ae44-be4cb680bb8a' so I guessed there was some kind of ownership issue. Right now, I'm playing with CI configuration to start the Docker check on a specific set of PRs (the PR of branches named fix-ci).

@Stevendeo
Copy link
Collaborator Author

The CI is currently broken, this PR aims at fixing the different CI issues.

@Stevendeo Stevendeo force-pushed the fix-ci branch 17 times, most recently from 69de101 to 40a6919 Compare July 26, 2022 13:45
@Stevendeo Stevendeo force-pushed the fix-ci branch 13 times, most recently from 8e98952 to e8348d6 Compare July 26, 2022 17:18
@Stevendeo Stevendeo changed the title Draft: Fix CI Fix CI Jul 26, 2022
@hra687261
Copy link
Contributor

This PR needs to be merged otherwise all new PRs and PRs that have recent commits will keep having failing CIs

@hra687261 hra687261 requested a review from Gbury September 15, 2022 09:03
@Gbury Gbury merged commit 0cd657c into OCamlPro:next Sep 20, 2022
@Gbury
Copy link
Collaborator

Gbury commented Sep 20, 2022

Well, looks like this actually broke CI once merged cc @Stevendeo , :p

@hra687261
Copy link
Contributor

It actually failed in a new way. The error is not the same as the one it fixes.
I created a PR #525 which should fix the new CI error

Stevendeo added a commit to Stevendeo/alt-ergo that referenced this pull request Nov 17, 2022
* Updating docker build for fixing CI

* Test

* Test

* Test

* Test

* All jobs

* Fix style

* Fix indent

* Trying to delay depext installation

* Trying without specifying depect

* Test fix
Halbaroth pushed a commit to Halbaroth/alt-ergo that referenced this pull request Jan 24, 2023
* Updating docker build for fixing CI

* Test

* Test

* Test

* Test

* All jobs

* Fix style

* Fix indent

* Trying to delay depext installation

* Trying without specifying depect

* Test fix
@Halbaroth Halbaroth modified the milestones: 2.4.2, 2.5.0 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants