Remove nums #600
Merged
Remove nums #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The parser and ast are still using num in this PR I believe, is that intentional? |
|
No, I didn't notice it... I modified the legacy parser to use only Zarith. |
bclement-ocp
approved these changes
May 22, 2023
There was a problem hiding this comment.
This looks good to me, please just remove the old code from the comments.
I believe decimal_number (and hexa_number) could be implemented with Q.of_string (Q.of_string ("0x" ^ x), respectively), but the specialized implementation is probably a tiny bit faster. Not that it matters much…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the support for the deprecated Nums library as suggested in #590.