Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit definitions for abs_{real,int} #750

Closed
wants to merge 1 commit into from

Conversation

bclement-ocp
Copy link
Collaborator

No description provided.

@bclement-ocp
Copy link
Collaborator Author

Draft because I need to rerun perfs.

@bclement-ocp
Copy link
Collaborator Author

After some more poking around, I don't think this is actually the right fix, but rather we should treat Abs_real and Abs_int as "internal" symbols for the floating-point theory and advise users to define their own abs functions rather than use the primitive ones for actual problems. IOW the abs_real and abs_int should only be used internally by the fpa theory to compute on constants, but not to define arbitrary problems. That seems to be the combination that works best in local tests.

This probably should be extended to {min,max}_{int,real} and integer_log2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant