Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_value sound by not stating a formula is false when it is absent from the environment #942

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Make get_value sound by not stating a formula is false when it is absent from the environment #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/reasoners/fun_sat.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1852,7 +1852,12 @@ module Make (Th : Theory.S) : Sat_solver_sig.S = struct
| Ty.Tbool ->
begin
match ME.find_opt t env.gamma with
| None -> Some E.faux
| None ->
begin
match ME.find_opt (E.neg t) env.gamma with
| None -> None
| Some _ -> Some E.faux
end
| Some _ -> Some E.vrai
end
| _ -> None
Expand Down
7 changes: 6 additions & 1 deletion src/lib/reasoners/satml_frontend.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,7 +1389,12 @@ module Make (Th : Theory.S) : Sat_solver_sig.S = struct
| Ty.Tbool ->
begin
match ME.find_opt t env.gamma with
| None -> Some E.faux
| None ->
begin
match ME.find_opt (E.neg t) env.gamma with
| None -> None
| Some _ -> Some E.faux
end
| Some _ -> Some E.vrai
end
| _ -> None
Expand Down
2 changes: 1 addition & 1 deletion tests/models/bool/bool1.models.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ unknown
(
(define-fun q () Bool false)
)
((notp false)
((notp unknown)
(notnq true))


Expand Down
2 changes: 1 addition & 1 deletion tests/models/bool/bool2.models.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
unknown
(
)
((notx false))
((notx unknown))

2 changes: 1 addition & 1 deletion tests/models/bool/bool3.models.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ unknown
(define-fun y () Bool true)
)
((foo true)
(bar false))
(bar unknown))

Loading