Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a "universal" VSIX, with the LSP server compiled in JavaScript #93

Merged
merged 9 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 45 additions & 55 deletions .drom

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 12 additions & 1 deletion .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
- run: opam pin add . -y --no-action
if: ${{ ! steps.cache-opam.outputs.cache-hit }}

# - run: opam depext -y superbol-studio-oss superbol-vscode-platform polka-js-stubs interop-js-stubs node-js-stubs vscode-js-stubs vscode-languageclient-js-stubs vscode-json vscode-debugadapter vscode-debugprotocol superbol-free superbol_free_lib superbol_preprocs superbol_project cobol_common cobol_parser cobol_ptree ebcdic_lib cobol_lsp ppx_cobcflags pretty cobol_config cobol_indent cobol_indent_old cobol_preproc cobol_data cobol_typeck cobol_unit ez_toml ezr_toml sql_ast sql_parser cobol_cfg
# - run: opam depext -y superbol-studio-oss superbol-vscode-platform interop-js-stubs node-js-stubs vscode-js-stubs vscode-languageclient-js-stubs vscode-json vscode-debugadapter vscode-debugprotocol superbol-free superbol_free_lib superbol_preprocs superbol_project cobol_common cobol_parser cobol_ptree ebcdic_lib cobol_lsp ppx_cobcflags pretty cobol_config cobol_indent cobol_indent_old cobol_preproc cobol_data cobol_typeck cobol_unit ez_toml ezr_toml sql_ast sql_parser cobol_cfg
# if: ${{ ! steps.cache-opam.outputs.cache-hit }}

- run: |
Expand Down Expand Up @@ -123,6 +123,17 @@ jobs:
compression-level: 0 # no compression (already a zip archive)
if: matrix.build_vsix

- run: make vsix-debug TARGET_PLAT=universal
if: ${{ matrix.build_vsix && matrix.os == 'ubuntu-latest' }}

- name: Upload universal VSIX artifact
uses: actions/upload-artifact@v4
with:
name: VSIX-universal
path: superbol-vscode-platform-*-universal-*.vsix
compression-level: 0 # no compression (already a zip archive)
if: ${{ matrix.build_vsix && matrix.os == 'ubuntu-latest' }}

# - name: Check whether source is well formatted
# run: make fmt
# continue-on-error: true
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/superbol-studio-oss
/superbol-vscode-platform
/polka-js-stubs
/interop-js-stubs
/node-js-stubs
/vscode-js-stubs
Expand Down
5 changes: 4 additions & 1 deletion Makefile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Makefile.drom-tpl
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ build:
ifeq ($(TARGET_PLAT)_$(BUILD_STATIC_EXECS),linux_true)
./scripts/static-build.sh
else
${DUNE} build!{build-profile} ${DUNE_ARGS} ${DUNE_CROSS_ARGS} @build
ifeq ($(TARGET_PLAT),linux)
${DUNE} build!{build-profile} ${DUNE_ARGS} ${DUNE_CROSS_ARGS} @install
./scripts/copy-bin.sh !{packages}
endif
endif
./scripts/after.sh build

Expand Down
Loading