Issue new release?

[emiliom]

Some important enhancements and bug fixes were issued last month, at least on a development branch. These are needed by the ODM2 REST API (ODM2/ODM2RESTfulWebServices#59)

Besides, the last odm2api tagged release was issued 6 months ago. So, it seems like this is a good time to work towards a new release.

@horsburgh, do you agree? Someone from your team would need to take the initiative to merge the relevant dev branch into master. Then, if you'd like our help, Don and I can issue the tagged release.

In the meantime, I've added comments to 3 of the latest issues (#118, #124, #127) to learn about the status of the bugs or enhancements they discussed, and see if any of them can go into the next release.

Thanks!

cc @aufdenkampe

[emiliom]

• Add related-sampling-features object methods #124 was already implemented (see it on the API docs.
  • @lsetiawan, can you confirm that it was added in the last 6 months? In that case, we'll add this to the release notes.
• getResultValues dataframe column names are not CamelCase #127 was addressed on 1/6. This will be a disruptive change (all existing code that uses output from this function will need to be upgraded to the case-sensitive dataframe column names), so we'll need to advertise the change in advance.
  • 1/9: I've reopened a discussion to see if we can implement this change more gradually, initially as an option rather than as the default.

Let's start compiling here all major new features and major bug fixes, to go into the release notes.

[lsetiawan]

#124 was already implemented (see it on the API docs.) can you confirm that it was added in the last 6 months? In that case, we'll add this to the release notes.

It looks like getRelatedSamplingFeatures has been around since April 2016 See 599b6cd.

[lsetiawan]

The last release was in May 26, 2017. Here are the major changes that occurred to the API since then.

• Fix person and organization filter for affiliations #96 Fix person and organization filter for affiliations.
• Improve getAffiliation docstring to follow numpy/scipy documentation #98 Improve documentation to follow google doc style. (Still Ongoing)
• Docs #99 Created a sphinx based Documentation
• Python 3 compatibility and flake8 #111 Python 3 Compatibility and Flake 8 Improvements
• Sfdataset #121 Created getSamplingFeatureDatasets
• Dsresults #122 Created getDatasetsResults and Improved getDatasets
• Sfresults #123 Improved getResults
• Sfdataset #125 Updated the structure of the resulting object from getSamplingFeatureDatasets
• Fix Processing Levels code and docstring #129 Fix bug in getProcessingLevels
• Fixed getSamplingFeatureDatasets issue #130 #131 Fix bug in getSamplingFeatureDatasets
• Error in DataLoggerFiles and DataLoggerFileColumns #132 #134 Fix bug in model DataloggerFiles and DataloggerFileColumns

[aufdenkampe]

On today's BiG CZ call, we decided to:

1. Tag release as "Release 0.7.0", removing “pre-release”, “alpha” and/or “beta” tags. We're well beyond that, with 6 previous releases and several repos that now depend on this one!

2. Start using Milestones to organize issues for the next release. We've used them well in other repos, but haven't done a good job with this repo. See https://github.com/ODM2/ODM2PythonAPI/milestones.

[aufdenkampe]

@lsetiawan, do you think you could look at the remaining open issues in these open Milestones and close both issues and Milestones if you think they were completed?

• Milestone: alpha Release 0.5. https://github.com/ODM2/ODM2PythonAPI/milestone/1
• Milestone: 0.6.0. https://github.com/ODM2/ODM2PythonAPI/milestone/2

You could even create a new Milestone 0.7, then tag all the fixed issues (closed or still open) as you list above with that Milestone, to keep track of which issues were completed with this release.

[emiliom]

@lsetiawan: I said you were done, but I do have one thing to ask you to help me with issuing the release: could you merge the development branch into master, Friday morning? Feel free to add me as a reviewer on the PR.

@aufdenkampe, regarding this comment:

You could even create a new Milestone 0.7, then tag all the fixed issues (closed or still open) as you list above with that Milestone, to keep track of which issues were completed with this release.

I believe Don mentioned already at the call that we've tracked the issues and bug fixes going into this new release. They will be part of the release notes. So, creating a "restropective" milestone for this release just adds more work w/o the value of having a milestone for tracking issue progress. So, we'll skip it for this release -- which I plan to issue on Friday.

"Milestone 0.6.0" was something I created ages ago, accompanied by an issue (#64) listing potential targets. No one ever commented on my suggested milestone targets, and in the end the milestone wish list did not reflect reality as it happened. I've deleted the milestone, but kept the issue for now to help future assessments of potential to-do's.

[emiliom]

New release is now ready and stamped:
https://github.com/ODM2/ODM2PythonAPI/releases/tag/v0.7.0
Request for new conda package is in the books, for Filipe:
ODM2/conda-recipes-ODM2#71

Onward and upwards!

There's one issue that I think needs to be discussed soon, before odm2api can be seen as really stable. Currently the package has a packager/folder hierarchy that includes a now-useless "ODM2" folder:
https://github.com/ODM2/ODM2PythonAPI/tree/master/odm2api/ODM2

That forces most module import statements to include the useless ODM2 package hierarchy (eg, odm2api.ODM2.services.readService). We'll need to get rid of the ODM2 folder hierarchy, and the sooner we do it the better, to minimize disruptions. I strongly recommend that we do it in the next release, giving ourselves plenty of time for all code that uses odm2api to make the adjustment.

I can discuss this when I'm back from travels, after the 29th.

[aufdenkampe]

@emiliom, thank you for making this release happen, developing helpful release notes, and queuing up a conda package release.

I'm very much a fan of moving forward soon with the next release to remove the useless "ODM2" level of hierarchy, and also changing the default column labels to CamelCase. With release v0.7 minted as is, any software that depends on the old conventions still have handy access to that version, while we can move forward with migrating our actively developed stuff to our widespread conventions.

[emiliom]

I'm reopening this only b/c there are some discussions and notes here that I'd like to capture and move elsewhere. FYI, also intend to go back to very old issues to clean up the repo's issues. But that won't happen until mid February.

[lsetiawan]

I think we should issue a release of v0.7.1 before further optimization work. Here are the changes that happened since the last release (Jan 19, 2018):

• Samplingfeaturedataset dev #143 Added eager loading for samplingfeaturedataset to try and cut down on query time.
• Deprecate odm2 #147 Created Future deprecation warning for ODM2 modules.
• use conda-forge #148 Move to conda-forge and deprecate ODM2 conda channel.
• Update README DOCS #151 Updated README to reflect changes to conda-forge channel and how to install the latest development version.

[aufdenkampe]

I think that's a great idea.