Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App rename and folder restructuring #73

Merged
merged 8 commits into from
Jan 8, 2018
Merged

Conversation

lsetiawan
Copy link
Member

Overview

This PR renames api to a cleared name as odm2_rest_api I am doing this so that we can have a reusable app that will probably be called django-odm2-rest-api, which then applications like ODM2-Admin or other django app can use this within the application rather than separately. The details are still in flux.

@emiliom
Copy link
Member

emiliom commented Jan 2, 2018

Let's talk about it a bit, before merging.

@lsetiawan
Copy link
Member Author

Note

Failures are due to incorrect testing mechanism. python examples/manage.py test odm2rest; does not work for installed pip packages. I get

ImportError: 'tests' module incorrectly imported from '/home/travis/miniconda/envs/TEST/lib/python2.7/site-packages/odm2rest'. Expected '/home/travis/build/ODM2/ODM2RESTfulWebServices/odm2rest'. Is this module globally installed?

@lsetiawan
Copy link
Member Author

@emiliom I've changed the name to odm2rest let me know if you like that. If so, I'll merge this for now as I work on figuring out the fix to travis and the correct testing way.

@emiliom
Copy link
Member

emiliom commented Jan 5, 2018

@emiliom I've changed the name to odm2rest

That's exactly what I was going to suggest just now! I like hos it's brief and consistent/parallel with odm2api.

There's no way I can truly review this PR. So, I trust you 😉. TravisCI failed, but I can't remember if there are tests that are working. So, you have my blessing to merge the PR yourself 👍

@lsetiawan lsetiawan merged commit b7ecaa6 into ODM2:master Jan 8, 2018
@lsetiawan lsetiawan deleted the app_rename branch January 8, 2018 20:56
@lsetiawan lsetiawan mentioned this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants