Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to Fill Gaps with -9999 values #201

Closed
AmberSJones opened this issue Oct 27, 2014 · 9 comments
Closed

Button to Fill Gaps with -9999 values #201

AmberSJones opened this issue Oct 27, 2014 · 9 comments

Comments

@AmberSJones
Copy link
Member

The technicians have requested a button that would insert -9999 into gaps that have been identified by the gap filter. I don't know that this HAS to be done, but we should discuss it when we're prioritizing feature requests.

@sreeder
Copy link
Contributor

sreeder commented Oct 3, 2016

@AmberSJones This is ready for testing on the nodvfill branch. the gui is a rough sketch, needs a little work before it is done.

@AmberSJones
Copy link
Member Author

AmberSJones commented Oct 11, 2016

I cannot get any series to plot using this branch?
image

@sreeder
Copy link
Contributor

sreeder commented Oct 11, 2016

what version of pandas are you using? there was some code that was deprecated so I tried to fix it. but it looks like I may have done that too soon.

@sreeder
Copy link
Contributor

sreeder commented Oct 11, 2016

@AmberSJones reverted to deprecated version until we are ready update the library requirements

@AmberSJones
Copy link
Member Author

This is looking good, but I think the form needs a little work. Let's add the text:
"This function fills any gaps less than the gap duration with a no-data value at the fill frequency."
Change the labels to be "Gap Duration:" and "Fill Frequency:"
Also, the fields on the form need to be lined up.
image

Furthermore- looks like the units that it is using to fill the gaps are off. i.e., I try to fill with 15 minute data and it fills every 15 hours.

sreeder pushed a commit that referenced this issue Oct 11, 2016
sreeder pushed a commit that referenced this issue Oct 11, 2016
sreeder pushed a commit that referenced this issue Oct 11, 2016
sreeder pushed a commit that referenced this issue Oct 12, 2016
@sreeder
Copy link
Contributor

sreeder commented Oct 12, 2016

@AmberSJones ready for testing

@AmberSJones
Copy link
Member Author

AmberSJones commented Oct 17, 2016

Ok- seems to be working well. Needs a couple tweaks to the form:

  • Needs a period at the end.
  • Should be 'greater than' rather than 'less than'. (that was my fault)

Note that the correct points appear to have been created at the correct intervals, etc., but the table doesn't function as expected with sorting by ValueID or by LocalDateTime.

@sreeder
Copy link
Contributor

sreeder commented Oct 17, 2016

@AmberSJones the form is ready for testing again. In what way is it not behaving as expected?

This was referenced Oct 17, 2016
@sreeder sreeder self-assigned this Oct 17, 2016
@AmberSJones
Copy link
Member Author

The form is great.

Re. the table- I assumed that sorting by ValueID would bring the 'nan' of the newly-added points to the top (or bottom) of the table. LocalDateTime seems ok- not sure what I was referring to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants