Custom method can now have nullable parameters and nullable arguments #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
reviewed
Nov 13, 2023
| @@ -761,7 +761,7 @@ protected virtual Expression BindCustomMethodExpressionOrNull(SingleValueFunctio | |||
| MethodInfo methodInfo; | |||
| if (UriFunctionsBinder.TryGetMethodInfo(node.Name, methodArgumentsType, out methodInfo)) | |||
| { | |||
| return ExpressionBinderHelper.MakeFunctionCall(methodInfo, context.QuerySettings, arguments); | |||
There was a problem hiding this comment.
I have trouble seeing why HandleNullPropagation check is needed in custom functions. Do you know of a use case where this could be used for custom functions?
There was a problem hiding this comment.
@xuzhg Any comment to my question
…nctionCall in wrong method
KenitoInc
requested review from
KenitoInc,
habbes,
mikepizzo,
corranrogue9,
ElizabethOkerio and
gathogojr
|
Please add a description to what the pr does. |
|
Please add some test to this Pr |
|
@xuzhg I know this PR is old but it is still relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
This PR will make it possible to create custom function for nullable types.