Cherry-pick (a77ed76): Fix AutoExpand Issues with Capitalized $Expand System Query Options #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
previously approved these changes
Sep 19, 2024
test/Microsoft.AspNetCore.OData.E2E.Tests/AutoExpand/AutoExpandDataModel.cs
Show resolved
Hide resolved
habbes
approved these changes
Oct 8, 2024
habbes
reviewed
Oct 8, 2024
| @@ -869,7 +869,7 @@ internal void AddAutoSelectExpandProperties() | |||
|
|
|||
| private IDictionary<string, string> GetODataQueryParameters() | |||
| { | |||
| Dictionary<string, string> result = new Dictionary<string, string>(); | |||
| Dictionary<string, string> result = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase); | |||
There was a problem hiding this comment.
Is case-insensitivity always supported, or does the user need to toggle some option?
There was a problem hiding this comment.
@habbes EnableCaseInsensitive is by default true:
IServiceProvider BuildRouteContainer(..)
There was a problem hiding this comment.
.AddRouteComponents(..) will call BuildRouteContainer(..) to build service provider with IEdmModel and service collections.
ODataOptions AddRouteComponents(..)
builder.Services.AddControllers().AddOData(
opt => opt.Count().Filter().Expand().Select().OrderBy().SetMaxTop(5).AddRouteComponents("odata",EdmModelBuilder.GetEdmModel()));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick a77ed76
Checklist (Uncheck if it is not completed)