Fix vulnerable dependencies in newtonsoft.json#1489
Merged
WanjohiSammy merged 4 commits intomainfrom Jun 18, 2025
Merged
Conversation
Member
Author
|
/AzurePipeline run OData-AspNetCoreOData-main-rolling-1ES |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a known vulnerability by updating key package dependencies used by Newtonsoft.Json.
- Upgrade Microsoft.AspNetCore.Mvc.NewtonsoftJson from version 5.0.0 to 8.0.17
- Upgrade Microsoft.CodeAnalysis.FxCopAnalyzers from version 2.9.8 to 3.3.2
Comments suppressed due to low confidence (2)
src/Microsoft.AspNetCore.OData.NewtonsoftJson/Microsoft.AspNetCore.OData.NewtonsoftJson.csproj:19
- The upgrade to version 8.0.17 may introduce breaking changes in API behavior compared to version 5.0.0. It is recommended to review the migration guide and update related code if necessary.
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.17" />
src/Microsoft.AspNetCore.OData.NewtonsoftJson/Microsoft.AspNetCore.OData.NewtonsoftJson.csproj:20
- The new version of FxCopAnalyzers may enforce additional or modified rules. Please verify that the codebase complies with any new analyzer recommendations.
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.2">
KenitoInc
previously approved these changes
Jun 16, 2025
gathogojr
previously approved these changes
Jun 16, 2025
xuzhg
approved these changes
Jun 16, 2025
xuzhg
previously approved these changes
Jun 16, 2025
src/Microsoft.AspNetCore.OData.NewtonsoftJson/Microsoft.AspNetCore.OData.NewtonsoftJson.csproj
Outdated
Show resolved
Hide resolved
Member
Author
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/AzurePipeline run |
|
No pipelines are associated with this pull request. |
…ysis.NetAnalyzers
…ub.com/OData/AspNetCoreOData into fix/upgrade-dependencies-vulnerability
WanjohiSammy
dismissed stale reviews from xuzhg, gathogojr, and KenitoInc
via
78ca070
Member
Author
|
/AzurePipelines run OData-AspNetCoreOData-main-rolling-1ES |
|
No pipelines are associated with this pull request. |
This was referenced Oct 17, 2025
This was referenced Oct 28, 2025
This was referenced Nov 13, 2025
This was referenced Dec 3, 2025
This was referenced Dec 10, 2025
This was referenced Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
Newtonsoft.Jsonprior to version 13.0.1 is vulnerable to Insecure Defaults due to improper handling of expressions with high nesting level that lead to StackOverFlow exception or high CPU and RAM usage.This PR handles this security vulnerabilities by updating affected dependencies:
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.