Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint routing #731

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Endpoint routing #731

merged 5 commits into from
Nov 16, 2023

Conversation

jspuij
Copy link
Contributor

@jspuij jspuij commented Oct 16, 2023

Description

This pull request adds endpoint routing support for Restier with OData 7.4+ on aspnet.core.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

I'm not sure about the syntax for AddEndpointRestier instead of AddRestier. This might need a bit of discussion.

@jspuij
Copy link
Contributor Author

jspuij commented Oct 16, 2023

Hi @robertmclaws. Was able to devote some time to Restier. One of the things on the todo list was endpoint routing. This pull request adds support for it, including some unit tests. Let me know what you think.

Also, I have some more time, so if you want me to think about an overhaul, OData webapi 8 support, or dotnet 8 support, I'm in.

@robertmclaws robertmclaws merged commit 7a43a18 into OData:main Nov 16, 2023
1 check passed
@robertmclaws
Copy link
Collaborator

robertmclaws commented Nov 20, 2023

Hey @jspuij! Just so you are aware, this change required a much more intensive refactor than you might have anticipated. As I started to expand the tests, I encountered a fundamental limitation with how RouteNames are handled in Endpoint Routing, which required us to expand Endpoint Routing support to the full test suite.

That meant I had to make changes to your API design, but I think the end result meshes much more closely with developer expectations. You can follow that work here:

https://github.com/OData/RESTier/pull/738/files

Thanks for jumpstarting this process for us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants