Refactoring the Endpoint Routing API #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename a bunch of classes (they might break people using reflection but should not be a big deal). - Refactor `AddRestier()` so that handles both Legacy and Endpoint routing. - Call `AddControllers()` in both cases because the services involved are minimal and people will expect similar behavior. - Make the return values consistent so we can reduce complexity on the test classes. - Still need to refactor the test suite to run the FULL GAMUT of tests on ASP.NET Core for both types of routing. That will be fun to figure out.
robertmclaws
commented
Nov 18, 2023
src/Microsoft.Restier.AspNetCore/Extensions/Restier_IServiceCollectionExtensions.cs
Show resolved
Hide resolved
- Dual routing test pattern created - LFG!!!
…for .NET 6+ and add a compatibility property that is irnored on our internal ASP.NET class - Breakdance fixes for plumbing useEndpointRouting wherever necessary. - Implementing the new pattern for unit tests, part 1
robertmclaws
changed the title
robertmclaws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddRestier()so that handles both Legacy and Endpoint routing.AddControllers()in both cases because the services involved are minimal and people will expect similar behavior.Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.