Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mqtt #130

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix mqtt #130

merged 2 commits into from
Oct 29, 2024

Conversation

maurerle
Copy link
Collaborator

@maurerle maurerle commented Oct 29, 2024

Added Agents ended up having ("localhost", 1883) as self.context.addr, which is not a valid topic - though self.context.addr is used as the topic in the mqtt container.

This is weird, as it sends messages always externally, even if they come from an internal agent (as the internal agent has ("localhost", 1883) as address while self.inbox_topic is something different).

Furthermore the inbox topic is currently optional, yet it does not work without specifying one.
It would be great to have the easier usage by using the client_id if no input_topic is given (as it was before I think?).

This PR also adds a test which fails without the given fix, due to the above described issue.

Furthermore, this creates agents with ("localhost", 1883) as self.context.addr, which is not a valid topic - though self.context.addr is used as the topic in the mqtt container
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.65%. Comparing base (5a557d9) to head (98bc958).
Report is 8 commits behind head on development.

Files with missing lines Patch % Lines
mango/container/mqtt.py 64.28% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #130      +/-   ##
===============================================
+ Coverage        88.56%   88.65%   +0.09%     
===============================================
  Files               22       22              
  Lines             2404     2407       +3     
===============================================
+ Hits              2129     2134       +5     
+ Misses             275      273       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcschrg rcschrg merged commit b0c1850 into OFFIS-DAI:development Oct 29, 2024
10 of 11 checks passed
@maurerle maurerle deleted the fix_mqtt branch October 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants