Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Agents ended up having ("localhost", 1883) as self.context.addr, which is not a valid topic - though self.context.addr is used as the topic in the mqtt container.
This is weird, as it sends messages always externally, even if they come from an internal agent (as the internal agent has
("localhost", 1883)
as address while self.inbox_topic is something different).Furthermore the inbox topic is currently optional, yet it does not work without specifying one.
It would be great to have the easier usage by using the
client_id
if noinput_topic
is given (as it was before I think?).This PR also adds a test which fails without the given fix, due to the above described issue.