Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to register agents after activation of container #132

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

maurerle
Copy link
Collaborator

this makes sure that the agent._do_start and agent.on_ready functions are called as expected

this also fixes a bug in runtime management of the external_coupling container, which did set running before starting the container.

this makes sure that the agent._do_start and agent.on_ready functions are called as expected
@maurerle maurerle requested a review from rcschrg October 31, 2024 09:19
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (b0c1850) to head (b0c8a1d).
Report is 2 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #132      +/-   ##
===============================================
+ Coverage        88.65%   88.69%   +0.03%     
===============================================
  Files               22       22              
  Lines             2407     2415       +8     
===============================================
+ Hits              2134     2142       +8     
  Misses             273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rcschrg rcschrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I also implemented this on another branch and just forgot to merge it. However, your version is actually better :)

@rcschrg rcschrg merged commit 8e18b31 into development Nov 1, 2024
11 checks passed
@maurerle maurerle deleted the test_agent_state branch November 1, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants