Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exporter option: Export only key frames #127

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

oldmanauz
Copy link
Contributor

  1. Added an export option to only export key frames of an animation.
  2. Updated documentation

The exporter will now only export key frames of an animation.
io_ogre/ogre/skeleton.py Outdated Show resolved Hide resolved
@paroj
Copy link
Member

paroj commented Sep 29, 2021

Also I just noticed issue #87. I haven't looked yet, but if this code is easily portable, do you want an option for node animation to export only key frames or be the ONLY option when exporting key frames?

an option just like the one you introduced here.

@sercero
Copy link
Collaborator

sercero commented Sep 30, 2021

@oldmanauz be careful because the idea of exporting every frame is to have Blender do the interpolation instead of OGRE. That is because there are some complex interpolations that OGRE cannot do.

And even the interpolations that OGRE can do, there is a loss of information because it is possible to tune the interpolation curves in Blender and OGRE would be none the wiser, please take that into account in your modifications.

Thanks!

@oldmanauz
Copy link
Contributor Author

@sercero I realise it does has limitations but It does solve a purpose. I documented that accordingly.

From what I see, I pretty much did exactly the same as what you started to implement in export_node. Did you try to get any futher with your version or did you just stop at exporting key frames every frame?

@paroj paroj merged commit 3952f5e into OGRECave:master Sep 30, 2021
@sercero
Copy link
Collaborator

sercero commented Oct 2, 2021

@sercero I realise it does has limitations but It does solve a purpose. I documented that accordingly.

From what I see, I pretty much did exactly the same as what you started to implement in export_node. Did you try to get any futher with your version or did you just stop at exporting key frames every frame?

I just stopped at exporting key frames every frame because my approach did not seem good enough, perhaps you came out with something better.

@oldmanauz oldmanauz deleted the export_only_keyframes branch October 2, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants