Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coregististration Report Bugs #159

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Coregististration Report Bugs #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2026aa9
Fixed bug related to the coregistration reporting.
cgohil8 Feb 8, 2023
13b2555
Added defaults to source reconstruction wrappers.
cgohil8 Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osl/report/templates/src_subject_panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ <h3>{{ data.fif_id }} &ensp; ({{ data.num }} of {{ data.total }})</h3>

<div class="flex-child" style="flex: 1">
<div class="tab" style="display: grid">
{% if data.coreg %}
{% if data.coregister %}
<button class="button1" onclick="openTab(event, '{{ data.fif_id }}_coregistration', this.id)" style="border-top-style: solid">Coregistration</button>
{% endif %}
{% if data.beamform or data.beamform_and_parcellate %}
Expand All @@ -22,7 +22,7 @@ <h3>{{ data.fif_id }} &ensp; ({{ data.num }} of {{ data.total }})</h3>

<div class="flex-child" style="flex: 5; padding-left: 25px">

{% if data.coreg %}
{% if data.coregister %}
<div class="tabpage" style='width: 100%' id={{ data.fif_id }}_coregistration>
<h3>Coregistration</h3>
<iframe data-src="{{ data.plt_coreg }}" width="525" height="525" id="{{ data.fif_id}}_coregistration_iframe"></iframe>
Expand Down
4 changes: 2 additions & 2 deletions osl/report/templates/src_summary_panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="flex-child" style="flex: 1">
<div class="tab" style="display: grid">
<button class="button1" onclick="openTab(event, 'config', this.id)" style="border-top-style: solid">Config</button>
{% if data.coreg %}
{% if data.coregister %}
<button class="button1" onclick="openTab(event, 'coregistration', this.id)" style="border-top-style: solid">Coregistration</button>
{% endif %}
{% if data.beamform_and_parcellate %}
Expand All @@ -23,7 +23,7 @@ <h3>Config</h3>
<img src="{{ data.plt_config }}" alt="" style='max-width: 60%'/>
</div>

{% if data.coreg %}
{% if data.coregister %}
<div class="tabpage" style='width: 100%' id='coregistration'>
<h3>Coregistration</h3>
{% if data.coreg_table is defined %}
Expand Down
16 changes: 8 additions & 8 deletions osl/source_recon/wrappers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def compute_surfaces(
preproc_file,
smri_file,
epoch_file,
include_nose,
include_nose=True,
recompute_surfaces=False,
):
"""Wrapper for computing surfaces.
Expand Down Expand Up @@ -130,8 +130,8 @@ def coregister(
preproc_file,
smri_file,
epoch_file,
use_nose,
use_headshape,
use_nose=True,
use_headshape=True,
already_coregistered=False,
allow_smri_scaling=False,
n_init=30,
Expand Down Expand Up @@ -214,7 +214,7 @@ def forward_model(
preproc_file,
smri_file,
epoch_file,
model,
model="Single Layer",
eeg=False,
):
"""Wrapper for computing the forward model.
Expand Down Expand Up @@ -259,10 +259,10 @@ def compute_surfaces_coregister_and_forward_model(
preproc_file,
smri_file,
epoch_file,
include_nose,
use_nose,
use_headshape,
model,
include_nose=True,
use_nose=True,
use_headshape=True,
model="Single Layer",
recompute_surfaces=False,
already_coregistered=False,
allow_smri_scaling=False,
Expand Down