Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Export template error on new Cohort #2825

Closed
anton-abushkevich opened this issue Feb 1, 2023 · 4 comments · Fixed by #2826
Closed

SQL Export template error on new Cohort #2825

anton-abushkevich opened this issue Feb 1, 2023 · 4 comments · Fixed by #2826
Assignees

Comments

@anton-abushkevich
Copy link
Contributor

Expected behavior

No errors.

Actual behavior

изображение

Steps to reproduce behavior

Create new cohort, observe console log.

@chrisknoll
Copy link
Collaborator

There is another issue related to this function, that we may be able to extend this issue to cover:

When you select other sources from the dropdown, the input boxes don't populate with the values of cdmschema, etc. I haven't looked closely a tthe code but what is surprising to me is that the text boxes for each of the paramaters is dynamically built based on what tokens are found in the SQL....but how does the values in the SOURCE map over to the tokens found in the SQL? Seems like this couldn't be done...unless you somehow hard coded that the token 'cdmdatabaseschema' maps over to the cdm schema in the source.

Steps to reproduce:

  1. Go to sql export
  2. Turn on checkbox that will make the replacements from th etextbox
  3. select a source to populate the input boxes based on the values from the Source.

anton-abushkevich added a commit that referenced this issue Feb 2, 2023
@anton-abushkevich
Copy link
Contributor Author

@chrisknoll I reproduced the issue you mentioned. For sure, parameter values should reflect selected source and it even worked before... Anyway, I fixed it and added to the PR - please check.

@chrisknoll
Copy link
Collaborator

Excellent, I will check this as soon as I am able. Thank you.

chrisknoll pushed a commit that referenced this issue Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants