Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Formatting with EditorConfig #655

Open
anthonysena opened this issue Apr 19, 2018 · 0 comments
Open

Code Formatting with EditorConfig #655

anthonysena opened this issue Apr 19, 2018 · 0 comments

Comments

@anthonysena
Copy link
Collaborator

Some time ago, code formatting was discussed on the OHDSI forums here:

http://forums.ohdsi.org/t/indent-rules-at-least-for-js-at-least-for-atlas/1783/8

The decision that was made based on a vote was to use tabs for indenting. @cerdman (
hoping I'm tagging the right person) proposed using http://editorconfig.org/ to enforce code formatting standards since it is a single file that is included in the repository and is compatible with many different IDEs.

From the architecture discussion today, we decided that this would be worthwhile to do after tackling #633 and putting it here so we don't lose track of it (again).

@anthonysena anthonysena added this to the V2.5.0 milestone May 24, 2018
@anthonysena anthonysena modified the milestones: Symposium 2018 Release, After Symposium Oct 5, 2018
@anthonysena anthonysena modified the milestones: After Symposium, V3.0.0. "Atlas 3.0" Jul 2, 2019
ssuvorov-fls added a commit that referenced this issue Oct 21, 2019
@rkboyce rkboyce moved this from Needs Review to Under Review in Atlas/WebAPI Issue Triage Apr 18, 2023
@chrisknoll chrisknoll moved this from Under Review to Review Complete in Atlas/WebAPI Issue Triage Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Review Complete
Development

No branches or pull requests

3 participants